Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 569613003: [New Tab Page] Add aria-hidden to an element. (Closed)

Created:
6 years, 3 months ago by Mathieu
Modified:
6 years, 3 months ago
Reviewers:
huangs
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[New Tab Page] Add aria-hidden to an element. Skips it during accessibility treatment. BUG=326793 Committed: https://crrev.com/c54cd222ccc48e66fcbc2db2b468afc7ee0d5c6b Cr-Commit-Position: refs/heads/master@{#294659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/local_ntp/local_ntp.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Hi Sam, Forgot during previous CR
6 years, 3 months ago (2014-09-12 15:22:49 UTC) #2
huangs
lgtm
6 years, 3 months ago (2014-09-12 18:53:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569613003/1
6 years, 3 months ago (2014-09-12 19:38:33 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-12 21:22:29 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:25:58 UTC) #8
Patchset 1 (id:??) landed as
https://crrev.com/c54cd222ccc48e66fcbc2db2b468afc7ee0d5c6b
Cr-Commit-Position: refs/heads/master@{#294659}

Powered by Google App Engine
This is Rietveld 408576698