Add the possibility to specify MediaStreamTrack::remote when creating a track.

Add the possibility to specify MediaStreamTrack::remote amd MediaStreamTrack::_readonly when creating a source.

This is to support MediaStreamTrack::remote and MediaStreamTrack::_readonly as specified in http://w3c.github.io/mediacapture-main/getusermedia.html#widl-MediaStreamTrack-remote.

Note that this does not updated the IDL file or add tests since I want to update the content parts before allowing JS to access these properties.

BUG=418540
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184246

[perkj_chrome, 2014-09-12 14:09:25]

perkj@chromium.org changed reviewers:
+ hta@chromium.org

[perkj_chrome, 2014-09-12 14:09:25]

Hej
Does it make sense to implement this?

[hta - Chromium, 2014-09-24 10:07:33]

This looks perfectly straightforward to me, and should be landed.

I assume the deprecated constructor goes away immediately after the calls have
changed in the Chrome side, so that there is no release that lets you see
remote=false for remote tracks.

https://codereview.chromium.org/569613002/diff/1/Source/platform/exported/Web...
File Source/platform/exported/WebMediaStreamTrack.cpp (right):

https://codereview.chromium.org/569613002/diff/1/Source/platform/exported/Web...
Source/platform/exported/WebMediaStreamTrack.cpp:87: initialize(id, source,
true);
This choice is strange, since it will make remote default to true. But I guess
it is strictly temporary.

[perkj_chrome, 2014-09-29 11:34:57]

Can you take another look Harald?

[hta - Chromium, 2014-09-29 12:42:10]

lgtm

[perkj_chrome, 2014-09-29 13:00:56]

perkj@chromium.org changed reviewers:
+ abarth@chromium.org, tommi@chromium.org

[perkj_chrome, 2014-09-29 13:00:56]

Adding tommi and abarth.

abarth - do you want to review this type of cls or is hta and tommi enough?

/Per

[tommi (sloooow) - chröme, 2014-09-30 18:46:52]

lgtm

[perkj_chrome, 2014-10-17 11:53:34]

Patchset #4 (id:60001) has been deleted

[perkj_chrome, 2014-10-17 11:54:58]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-10-17 11:55:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569613002/80001

[commit-bot: I haz the power, 2014-10-17 12:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-17 12:02:29]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[perkj_chrome, 2014-10-17 12:12:23]

perkj@chromium.org changed reviewers:
+ jochen@chromium.org

[perkj_chrome, 2014-10-17 12:12:23]

Jochen, would you mind?

[jochen (gone - plz use gerrit), 2014-10-20 13:25:31]

lgtm

https://codereview.chromium.org/569613002/diff/80001/public/platform/WebMedia...
File public/platform/WebMediaStreamSource.h (right):

https://codereview.chromium.org/569613002/diff/80001/public/platform/WebMedia...
public/platform/WebMediaStreamSource.h:87: BLINK_PLATFORM_EXPORT void
initialize(const WebString& id, Type, const WebString& name, bool remote, bool
readOnly);
nit. readonly

[perkj_chrome, 2014-10-21 09:03:57]

Patchset #5 (id:100001) has been deleted

[perkj_chrome, 2014-10-21 09:05:06]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-10-21 09:06:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569613002/140001

[commit-bot: I haz the power, 2014-10-21 10:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 10:20:22]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/3...)

[perkj_chrome, 2014-10-23 07:39:28]

The CQ bit was checked by perkj@chromium.org

[commit-bot: I haz the power, 2014-10-23 07:40:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569613002/160001

[commit-bot: I haz the power, 2014-10-23 08:41:53]

Committed patchset #7 (id:160001) as 184246