Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: remoting/host/client_session.h

Issue 569593002: Maintaining the proper order of initialization WeakPtrFactory in "src/remoting" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/host/client_session.cc » ('j') | remoting/host/win/host_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_HOST_CLIENT_SESSION_H_ 5 #ifndef REMOTING_HOST_CLIENT_SESSION_H_
6 #define REMOTING_HOST_CLIENT_SESSION_H_ 6 #define REMOTING_HOST_CLIENT_SESSION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 static scoped_ptr<VideoEncoder> CreateVideoEncoder( 166 static scoped_ptr<VideoEncoder> CreateVideoEncoder(
167 const protocol::SessionConfig& config); 167 const protocol::SessionConfig& config);
168 168
169 EventHandler* event_handler_; 169 EventHandler* event_handler_;
170 170
171 // The connection to the client. 171 // The connection to the client.
172 scoped_ptr<protocol::ConnectionToClient> connection_; 172 scoped_ptr<protocol::ConnectionToClient> connection_;
173 173
174 std::string client_jid_; 174 std::string client_jid_;
175 175
176 // Used to disable callbacks to |this| once DisconnectSession() has been
177 // called.
178 base::WeakPtrFactory<ClientSessionControl> control_factory_;
179
180 // Used to create a DesktopEnvironment instance for this session. 176 // Used to create a DesktopEnvironment instance for this session.
181 DesktopEnvironmentFactory* desktop_environment_factory_; 177 DesktopEnvironmentFactory* desktop_environment_factory_;
182 178
183 // The DesktopEnvironment instance for this session. 179 // The DesktopEnvironment instance for this session.
184 scoped_ptr<DesktopEnvironment> desktop_environment_; 180 scoped_ptr<DesktopEnvironment> desktop_environment_;
185 181
186 // Filter used as the final element in the input pipeline. 182 // Filter used as the final element in the input pipeline.
187 protocol::InputFilter host_input_filter_; 183 protocol::InputFilter host_input_filter_;
188 184
189 // Tracker used to release pressed keys and buttons when disconnecting. 185 // Tracker used to release pressed keys and buttons when disconnecting.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 scoped_ptr<GnubbyAuthHandler> gnubby_auth_handler_; 252 scoped_ptr<GnubbyAuthHandler> gnubby_auth_handler_;
257 253
258 // Used to manage extension functionality. 254 // Used to manage extension functionality.
259 scoped_ptr<HostExtensionSessionManager> extension_manager_; 255 scoped_ptr<HostExtensionSessionManager> extension_manager_;
260 256
261 // Used to store video channel pause & lossless parameters. 257 // Used to store video channel pause & lossless parameters.
262 bool pause_video_; 258 bool pause_video_;
263 bool lossless_video_encode_; 259 bool lossless_video_encode_;
264 bool lossless_video_color_; 260 bool lossless_video_color_;
265 261
262 // Used to disable callbacks to |this| once DisconnectSession() has been
263 // called.
264 base::WeakPtrFactory<ClientSessionControl> weak_factory_;
265
266 DISALLOW_COPY_AND_ASSIGN(ClientSession); 266 DISALLOW_COPY_AND_ASSIGN(ClientSession);
267 }; 267 };
268 268
269 } // namespace remoting 269 } // namespace remoting
270 270
271 #endif // REMOTING_HOST_CLIENT_SESSION_H_ 271 #endif // REMOTING_HOST_CLIENT_SESSION_H_
OLDNEW
« no previous file with comments | « no previous file | remoting/host/client_session.cc » ('j') | remoting/host/win/host_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698