Make dart2js deferred loading work in cps mode.

Make dart2js deferred loading work in CSP mode.

Still it will not work from a js-worker, because we use new Function to
evaluate the script instead of injecting a script tag.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40371

[sigurdm, 2014-09-12 13:09:31]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-09-12 17:00:18]

LGTM.

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:134:
List<jsAst.Node> precompiledFunction(OutputUnit outputUnit) {
precompiledFunctionsFor

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:139:
List<jsAst.Expression> precompiledConstructorNames(OutputUnit outputUnit) {
precompiledConstructorNamesFor

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:2046:
String hash = hashOfString(code);
Can't you do the hash after the cspcode?

[sigurdm, 2014-09-15 13:10:48]

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
(right):

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:134:
List<jsAst.Node> precompiledFunction(OutputUnit outputUnit) {
On 2014/09/12 17:00:18, floitsch wrote:
> precompiledFunctionsFor

Done.

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:139:
List<jsAst.Expression> precompiledConstructorNames(OutputUnit outputUnit) {
On 2014/09/12 17:00:17, floitsch wrote:
> precompiledConstructorNamesFor

Done.

https://codereview.chromium.org/569583002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:2046:
String hash = hashOfString(code);
On 2014/09/12 17:00:17, floitsch wrote:
> Can't you do the hash after the cspcode?

My thinking was that the csp-code follows deterministically from the other code
- therefore it has no utility in the hash - but I can see how it makes the code
more confusing

Done.

[ahe, 2014-09-15 13:44:55]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2014-09-15 13:44:56]

Updated the description, as my understanding is that this CL is about Content
Security Policy, not Continuation Passing Style.

Subject not changed so the email thread isn't forked.

[sigurdm, 2014-09-16 09:30:09]

Thanks, I'm afraid it won't be the last time I make that mistake.

[sigurdm, 2014-09-17 12:22:52]

Committed patchset #3 (id:40001) manually as 40371 (presubmit successful).