Remove --find-inode-switch hack from chrome-sandbox

Remove --find-inode-switch hack from chrome-sandbox

Chrome was modified back in May 2014 to use SCM_CREDENTIALS instead of
--find-inode-switch and we haven't any heard any negative feedback, so
it's time to remove --find-inode-switch entirely.

BUG=357670
Committed: https://crrev.com/3f37ce216d768da8795a80860b00a4ad45735bd9
Cr-Commit-Position: refs/heads/master@{#294649}

[mdempsky, 2014-09-12 17:33:37]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org

[mdempsky, 2014-09-12 17:36:19]

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
File sandbox/linux/suid/common/sandbox.h (right):

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
sandbox/linux/suid/common/sandbox.h:19: static const long kSUIDSandboxApiNumber
= 2;
As I think about it, I'm unsure if this really needs an API bump.  This number
is really only needed for the chain-exec behavior for launching the zygote,
whereas if chrome tries to invoke chrome-sandbox with --find-inode-switch then
it'll just get an error now.  So maybe we can leave the API number alone?

[jln (very slow on Chromium), 2014-09-12 18:03:38]

lgtm

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
File sandbox/linux/suid/common/sandbox.h (right):

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
sandbox/linux/suid/common/sandbox.h:19: static const long kSUIDSandboxApiNumber
= 2;
On 2014/09/12 17:36:19, mdempsky wrote:
> As I think about it, I'm unsure if this really needs an API bump.  This number
> is really only needed for the chain-exec behavior for launching the zygote,
> whereas if chrome tries to invoke chrome-sandbox with --find-inode-switch then
> it'll just get an error now.  So maybe we can leave the API number alone?

Yeah you're right, let's leave it alone it's not worth the cost.

[mdempsky, 2014-09-12 18:06:56]

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
File sandbox/linux/suid/common/sandbox.h (right):

https://codereview.chromium.org/569533002/diff/1/sandbox/linux/suid/common/sa...
sandbox/linux/suid/common/sandbox.h:19: static const long kSUIDSandboxApiNumber
= 2;
On 2014/09/12 18:03:38, jln wrote:
> On 2014/09/12 17:36:19, mdempsky wrote:
> > As I think about it, I'm unsure if this really needs an API bump.  This
number
> > is really only needed for the chain-exec behavior for launching the zygote,
> > whereas if chrome tries to invoke chrome-sandbox with --find-inode-switch
then
> > it'll just get an error now.  So maybe we can leave the API number alone?
> 
> Yeah you're right, let's leave it alone it's not worth the cost.

Done.

[mdempsky, 2014-09-12 18:06:59]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-09-12 18:19:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569533002/20001

[commit-bot: I haz the power, 2014-09-12 20:31:22]

Committed patchset #2 (id:20001) as 683c7abadf67dbbb114bef5942c19d1c240ed74d

[commit-bot: I haz the power, 2014-09-12 20:37:59]

Patchset 2 (id:??) landed as
https://crrev.com/3f37ce216d768da8795a80860b00a4ad45735bd9
Cr-Commit-Position: refs/heads/master@{#294649}