Index: extensions/browser/runtime_data_unittest.cc |
diff --git a/extensions/browser/runtime_data_unittest.cc b/extensions/browser/runtime_data_unittest.cc |
index 23b8098fb55515822a0f8f3eaddc7d281f8b1ef5..6253f8008a5139fcff5176b84b4dd14cc64404eb 100644 |
--- a/extensions/browser/runtime_data_unittest.cc |
+++ b/extensions/browser/runtime_data_unittest.cc |
@@ -10,21 +10,13 @@ |
#include "extensions/browser/extension_registry.h" |
#include "extensions/common/extension.h" |
#include "extensions/common/extension_builder.h" |
+#include "extensions/common/test_util.h" |
#include "extensions/common/value_builder.h" |
#include "testing/gtest/include/gtest/gtest.h" |
namespace extensions { |
namespace { |
-// Creates a very simple extension. |
-scoped_refptr<Extension> CreateExtension() { |
- return ExtensionBuilder() |
- .SetManifest( |
- DictionaryBuilder().Set("name", "test").Set("version", "0.1")) |
- .SetID("id1") |
- .Build(); |
-} |
- |
// Creates a very simple extension with a background page. |
scoped_refptr<Extension> CreateExtensionWithBackgroundPage() { |
return ExtensionBuilder() |
@@ -52,7 +44,7 @@ class RuntimeDataTest : public testing::Test { |
TEST_F(RuntimeDataTest, IsBackgroundPageReady) { |
// An extension without a background page is always considered ready. |
- scoped_refptr<Extension> no_background = CreateExtension(); |
+ scoped_refptr<Extension> no_background = test_util::CreateEmptyExtension(); |
EXPECT_TRUE(runtime_data_.IsBackgroundPageReady(no_background.get())); |
// An extension with a background page is not ready until the flag is set. |
@@ -68,7 +60,7 @@ TEST_F(RuntimeDataTest, IsBackgroundPageReady) { |
} |
TEST_F(RuntimeDataTest, IsBeingUpgraded) { |
- scoped_refptr<Extension> extension = CreateExtension(); |
+ scoped_refptr<Extension> extension = test_util::CreateEmptyExtension(); |
// An extension is not being upgraded until the flag is set. |
EXPECT_FALSE(runtime_data_.IsBeingUpgraded(extension.get())); |
@@ -81,7 +73,7 @@ TEST_F(RuntimeDataTest, IsBeingUpgraded) { |
} |
TEST_F(RuntimeDataTest, HasUsedWebRequest) { |
- scoped_refptr<Extension> extension = CreateExtension(); |
+ scoped_refptr<Extension> extension = test_util::CreateEmptyExtension(); |
// An extension has not used web request until the flag is set. |
EXPECT_FALSE(runtime_data_.HasUsedWebRequest(extension.get())); |