Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_function_test_utils.cc
diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc
index 03b4d7f9ef0c9a50cc8d8b6fae444aa6eae33114..503709b1a5ac7ac4e1d25bea9aac6bcb582074e4 100644
--- a/chrome/browser/extensions/extension_function_test_utils.cc
+++ b/chrome/browser/extensions/extension_function_test_utils.cc
@@ -103,10 +103,6 @@ base::ListValue* ToList(base::Value* val) {
return static_cast<base::ListValue*>(val);
}
-scoped_refptr<Extension> CreateEmptyExtension() {
- return CreateEmptyExtensionWithLocation(Manifest::INTERNAL);
-}
-
scoped_refptr<Extension> CreateEmptyExtensionWithLocation(
Manifest::Location location) {
scoped_ptr<base::DictionaryValue> test_extension_value(
@@ -114,14 +110,6 @@ scoped_refptr<Extension> CreateEmptyExtensionWithLocation(
return CreateExtension(location, test_extension_value.get(), std::string());
}
-scoped_refptr<Extension> CreateEmptyExtension(
- const std::string& id_input) {
- scoped_ptr<base::DictionaryValue> test_extension_value(
- ParseDictionary("{\"name\": \"Test\", \"version\": \"1.0\"}"));
- return CreateExtension(Manifest::INTERNAL, test_extension_value.get(),
- id_input);
-}
-
scoped_refptr<Extension> CreateExtension(
base::DictionaryValue* test_extension_value) {
return CreateExtension(Manifest::INTERNAL, test_extension_value,
« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.h ('k') | extensions/browser/api/api_resource_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698