chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc - Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browser/browser_apitest.cc ('k') | chrome/browser/extensions/api/identity/identity_apitest.cc » ('j') | chrome/browser/extensions/api/identity/identity_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

index 90f6425c81bc3bc426d2c4b853f73275b31caedd..2a57477b5d843a7fff23353b599f5d3ebc0178b9 100644

--- a/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc

@@ -25,6 +25,7 @@

#include "chromeos/dbus/mock_cryptohome_client.h"

#include "chromeos/settings/cros_settings_provider.h"

#include "components/policy/core/common/cloud/cloud_policy_constants.h"

+#include "extensions/common/test_util.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/cros_system_api/dbus/service_constants.h"

@@ -139,7 +140,7 @@ void GetCertificateCallbackFalse(

class EPKPChallengeKeyTestBase : public BrowserWithTestWindowTest {

protected:

EPKPChallengeKeyTestBase()

- : extension_(utils::CreateEmptyExtension("")) {

+ : extension_(test_util::CreateEmptyExtension()) {

// Set up the default behavior of mocks.

ON_CALL(mock_cryptohome_client_, TpmAttestationDoesKeyExist(_, _, _, _))

.WillByDefault(WithArgs<3>(Invoke(FakeBoolDBusMethod(