Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 569453002: Update sizes expectation for mini_installer.exe (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
5 years, 9 months ago
Reviewers:
engedy, weitao
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update xp-release/sizes/mini_installer.exe expectations. A 2MB+ regression was introduced but a cause cannot be identified. https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-xp&tests=sizes%2Fmini_installer.exe&checked=mini_installer.exe&rev=294272 BUG=413191 NOTRY=true TBR=weitaosu,engedy Committed: https://crrev.com/ed0021074af680d11d16f6eefac52f05b43d23f2 Cr-Commit-Position: refs/heads/master@{#294512}

Patch Set 1 #

Patch Set 2 : Disable spaceport benchmark on linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/benchmarks/spaceport.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Zeeshan Qureshi
Updating sizes to get the bot green, will track regression in bug.
6 years, 3 months ago (2014-09-11 22:00:45 UTC) #2
weitao
On 2014/09/11 22:00:45, Zeeshan Qureshi wrote: > Updating sizes to get the bot green, will ...
6 years, 3 months ago (2014-09-11 22:05:54 UTC) #5
Zeeshan Qureshi
On 2014/09/11 22:05:54, weitaosu wrote: > On 2014/09/11 22:00:45, Zeeshan Qureshi wrote: > > Updating ...
6 years, 3 months ago (2014-09-11 22:07:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569453002/1
6 years, 3 months ago (2014-09-11 22:24:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569453002/1
6 years, 3 months ago (2014-09-12 00:14:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as a693ce67bcd7e05c5ef168ab0875dd940520e273
6 years, 3 months ago (2014-09-12 00:56:55 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed0021074af680d11d16f6eefac52f05b43d23f2 Cr-Commit-Position: refs/heads/master@{#294512}
6 years, 3 months ago (2014-09-12 00:59:26 UTC) #13
engedy
6 years, 3 months ago (2014-09-12 09:58:48 UTC) #14
Message was sent while issue was closed.
On 2014/09/12 00:59:26, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ed0021074af680d11d16f6eefac52f05b43d23f2
> Cr-Commit-Position: refs/heads/master@{#294512}

LGTM, although I consider this more of a temporary fix. We probably do not want
to allow our installer increase in size by 2 megs overnight, therefore
*somebody* with more background should investigate more.

Powered by Google App Engine
This is Rietveld 408576698