Fix a ServiceWorker crasher

Fix a ServiceWorker crasher. We have to test the provider_host_ weakptr in async callbacks because the document can be closed, and the host deleted, in the interim.

BUG=414118
Committed: https://crrev.com/279f16422ffac905ecd74e9016d75da887b9954c
Cr-Commit-Position: refs/heads/master@{#294999}

[michaeln, 2014-09-15 22:23:48]

michaeln@chromium.org changed reviewers:
+ horo@chromium.org, nhiroki@chromium.org

[michaeln, 2014-09-15 22:23:48]

hi ptal, really doesn't need two reviewers, just whomever gets there first, thnx

[michaeln, 2014-09-15 22:26:09]

i have a test in the works that i'll upload soon too

[michaeln, 2014-09-16 00:35:12]

test is in snapshot #2

[nhiroki, 2014-09-16 00:49:47]

LGTM!

https://codereview.chromium.org/569423002/diff/20001/content/browser/service_...
File
content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
(right):

https://codereview.chromium.org/569423002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc:132:
registration_->SetWaitingVersion(version_.get());
nit: Pairing as follows might be more natural:

(1) SetStatus(ACTIVATED) && SetActiveVersion()
OR
(2) SetStatus(INSTALLED) && SetWaitingVersion()

[michaeln, 2014-09-16 00:53:39]

thnx

https://codereview.chromium.org/569423002/diff/20001/content/browser/service_...
File
content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
(right):

https://codereview.chromium.org/569423002/diff/20001/content/browser/service_...
content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc:132:
registration_->SetWaitingVersion(version_.get());
On 2014/09/16 00:49:46, nhiroki wrote:
> nit: Pairing as follows might be more natural:
> 
> (1) SetStatus(ACTIVATED) && SetActiveVersion()
> OR
> (2) SetStatus(INSTALLED) && SetWaitingVersion()

Done (doh!)

[michaeln, 2014-09-16 00:55:27]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-09-16 01:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569423002/40001

[nhiroki, 2014-09-16 01:35:08]

As per horo@'s CL (https://codereview.chromium.org/551843005/), this CL could
fix [1] and [2], too :D

[1] http://crbug.com/408880
[2] http://crbug.com/414170

[horo, 2014-09-16 02:00:56]

lgtm.
Thank you.

[commit-bot: I haz the power, 2014-09-16 02:28:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 02:28:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2014-09-16 03:16:41]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-09-16 03:17:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569423002/40001

[commit-bot: I haz the power, 2014-09-16 03:37:11]

Committed patchset #3 (id:40001) as 627820a8d2e047ade46d01998a1464f4a68533f8

[commit-bot: I haz the power, 2014-09-16 03:38:47]

Patchset 3 (id:??) landed as
https://crrev.com/279f16422ffac905ecd74e9016d75da887b9954c
Cr-Commit-Position: refs/heads/master@{#294999}

[michaeln, 2014-09-17 21:10:52]

Patchset #4 (id:60001) has been deleted