Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 569403004: Check whether a number is passed as an argument to kJSSetZoomLevel rather than a double. (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check whether a number is passed as an argument to kJSSetZoomLevel rather than a double. In the in-process PDF plugin when checking the argument type of kJSSetZoomLevel calls to the plugin we would check if the argument is a double. But it may be an int and we really want to check if it's a number. This probably worked in the past by chance and broke when we switched to using gin to implement JS bindings for Pepper. BUG=413525 Committed: https://crrev.com/69d475766c08be6411a8751861b3d09fcd24783d Cr-Commit-Position: refs/heads/master@{#295008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pdf/instance.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years, 3 months ago (2014-09-16 03:08:10 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-16 03:24:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569403004/1
6 years, 3 months ago (2014-09-16 03:37:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 21ba4d21f087dee438456eda8db8e7042f12ab0c
6 years, 3 months ago (2014-09-16 04:47:29 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 04:51:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69d475766c08be6411a8751861b3d09fcd24783d
Cr-Commit-Position: refs/heads/master@{#295008}

Powered by Google App Engine
This is Rietveld 408576698