Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: pkg/polymer/test/build/code_extractor.dart

Issue 569403003: update tests to use error message templates everywhere instead of hardcoded values (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/test/build/all_phases_test.dart ('k') | pkg/polymer/test/build/import_inliner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/code_extractor.dart
diff --git a/pkg/polymer/test/build/code_extractor.dart b/pkg/polymer/test/build/code_extractor.dart
index f14b235f7588774212e5e8de4670085a0bae691c..12b68ca3783c61366ef74f47d0a588850b4bfe58 100644
--- a/pkg/polymer/test/build/code_extractor.dart
+++ b/pkg/polymer/test/build/code_extractor.dart
@@ -251,7 +251,8 @@ validateUriTests() {
}, {
'a|web/test.html._data': EMPTY_DATA,
}, [
- 'warning: Script file at "a.dart" not found. (web/test.html 1 0)',
+ 'warning: ${SCRIPT_FILE_NOT_FOUND.create({'url': 'a.dart'}).snippet} '
+ '(web/test.html 1 0)',
]);
testPhases('many script src around, valid and invalid', phases, {
@@ -267,7 +268,9 @@ validateUriTests() {
}, {
'a|web/test.html._data': expectedData(['web/a.dart', 'web/c.dart']),
}, [
- 'warning: Script file at "b.dart" not found. (web/test.html 1 0)',
- 'warning: Script file at "d.dart" not found. (web/test.html 3 0)',
+ 'warning: ${SCRIPT_FILE_NOT_FOUND.create({'url': 'b.dart'}).snippet} '
+ '(web/test.html 1 0)',
+ 'warning: ${SCRIPT_FILE_NOT_FOUND.create({'url': 'd.dart'}).snippet} '
+ '(web/test.html 3 0)',
]);
}
« no previous file with comments | « pkg/polymer/test/build/all_phases_test.dart ('k') | pkg/polymer/test/build/import_inliner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698