Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 569373002: SkRecord: clean up comments and 4 bytes per SkRecord. (Closed)

Created:
6 years, 3 months ago by mtklein_skia
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkRecord: clean up comments and 4 bytes per SkRecord. Just happened to notice these while skimming through. The comments are a little out of date; now that we have visit/mutate, we do need O(1) random access. The constructor arguments are flexibility we're not using. BUG=skia: Committed: https://skia.googlesource.com/skia/+/db26a1267d57f6d8ef5b2fbdeb519be718fc1760

Patch Set 1 #

Patch Set 2 : unsigned #

Patch Set 3 : enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/core/SkRecord.h View 1 2 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
mtklein_skia
6 years, 3 months ago (2014-09-15 19:39:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569373002/1
6 years, 3 months ago (2014-09-15 19:40:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-15 19:40:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569373002/20001
6 years, 3 months ago (2014-09-15 19:43:33 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-15 19:43:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/688)
6 years, 3 months ago (2014-09-15 19:46:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569373002/40001
6 years, 3 months ago (2014-09-15 19:49:53 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-15 19:49:56 UTC) #13
f(malita)
lgtm
6 years, 3 months ago (2014-09-15 21:26:36 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:27:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as db26a1267d57f6d8ef5b2fbdeb519be718fc1760

Powered by Google App Engine
This is Rietveld 408576698