Change SkResourceCache to take a Visitor inside its find().

Change SkResourceCache to take a Visitor inside its find().

This reverts commit 595aa05efcb504e85358b8d328ac4a9fa1c46e2e.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c90e0149ec530075cae7bf51072a16628311855e

[reed1, 2014-09-15 18:15:41]

reed@google.com changed reviewers:
+ danakj@chromium.org, mtklein@google.com

[reed1, 2014-09-15 18:15:41]

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (left):

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp...
src/core/SkResourceCache.cpp:257: this->purgeAsNeeded();
The bug in the new CL was that we forgot to "purge" after the Add -- hence we
could overrun our budget!

[reed1, 2014-09-15 18:19:29]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-15 18:20:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569353002/20001

[commit-bot: I haz the power, 2014-09-15 18:20:20]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-16 00:20 UTC

[danakj, 2014-09-15 18:21:17]

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (left):

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp...
src/core/SkResourceCache.cpp:257: this->purgeAsNeeded();
On 2014/09/15 18:15:41, reed1 wrote:
> The bug in the new CL was that we forgot to "purge" after the Add -- hence we
> could overrun our budget!

Where is the purge in this CL then? I don't see one being added anywhere.

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp...
src/core/SkResourceCache.cpp:262: SkASSERT(0 == rec->fLockCount);
This seems reasonable to keep, while the fLockCount still exists?

[reed1, 2014-09-15 18:22:49]

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (left):

https://codereview.chromium.org/569353002/diff/1/src/core/SkResourceCache.cpp...
src/core/SkResourceCache.cpp:257: this->purgeAsNeeded();
On 2014/09/15 18:21:16, danakj wrote:
> On 2014/09/15 18:15:41, reed1 wrote:
> > The bug in the new CL was that we forgot to "purge" after the Add -- hence
we
> > could overrun our budget!
> 
> Where is the purge in this CL then? I don't see one being added anywhere.

Just wanted to post the original that I'm reverting.
patch #2 has the purge-fix.

[danakj, 2014-09-15 18:24:57]

ah, cool it just wasn't uploaded yet. thanks LGTM (but would prefer to keep that
assert)

[reed1, 2014-09-15 18:25:34]

On 2014/09/15 18:24:57, danakj wrote:
> ah, cool it just wasn't uploaded yet. thanks LGTM (but would prefer to keep
that
> assert)

But there is no fLockCount anymore...?

[danakj, 2014-09-15 18:26:05]

Oh! It acutally went away, sorry I missed that, that's awesome. Thanks :) LGTM+

[mtklein, 2014-09-15 18:38:43]

lgtm

[commit-bot: I haz the power, 2014-09-15 18:39:48]

Committed patchset #2 (id:20001) as c90e0149ec530075cae7bf51072a16628311855e