Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/build.py

Issue 569343003: Make 'tools/build.py -h' warn the user to run it from the repo root. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make fix more conservative: simply fail on wrong cwd. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
diff --git a/tools/build.py b/tools/build.py
index 4ca626230520a00ca8122fdd4e0705ea7fde9ace..805bca5711379e5e562781458b4440388e895605 100755
--- a/tools/build.py
+++ b/tools/build.py
@@ -511,6 +511,19 @@ def BuildCrossSdk(options, target_os, mode, arch):
def Main():
+ # This script assumes it is running from the repo root and can
+ # silently fail when that's not true. A more user friendly option
+ # would be to make it run from anywhere. For now we just fail early
+ # and loudly.
+ if os.path.abspath(utils.DART_DIR) != os.path.abspath(os.getcwd()):
Ivan Posva 2014/09/17 03:48:55 This is not entirely correct. Sometimes you need t
+ print 'This script must be run from the repo root!'
+ print 'Please cd into'
+ print ''
+ print ' %s' % utils.DART_DIR
+ print ''
+ print 'before running.'
+ return 1
+
utils.ConfigureJava()
# Parse the options.
parser = BuildOptions()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698