Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 569343002: Fix ProGuard issues after recent NavigationController refactoring (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ProGuard issues after recent NavigationController refactoring Annotate several NavigationController methods used only in testing, and remove a helper test function that is unused even in tests. BUG=398263 NOTRY=true Committed: https://crrev.com/2e9bcdf661d0231880bafc4be33f74b6f6b685a8 Cr-Commit-Position: refs/heads/master@{#294864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java View 6 chunks +8 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jdduke (slow)
aurimas@: PTAL. tedchoc@: Owner approval.
6 years, 3 months ago (2014-09-15 18:01:04 UTC) #2
aurimas (slooooooooow)
LGTM thanks for catching this!
6 years, 3 months ago (2014-09-15 18:03:04 UTC) #3
jdduke (slow)
On 2014/09/15 18:03:04, aurimas wrote: > LGTM thanks for catching this! TBR'ing ted as this ...
6 years, 3 months ago (2014-09-15 18:10:46 UTC) #4
Ted C
lgtm
6 years, 3 months ago (2014-09-15 18:13:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569343002/1
6 years, 3 months ago (2014-09-15 18:25:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as c75a69967b3e63ce8a163e3df2c1b53b6ede5165
6 years, 3 months ago (2014-09-15 19:16:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:21:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e9bcdf661d0231880bafc4be33f74b6f6b685a8
Cr-Commit-Position: refs/heads/master@{#294864}

Powered by Google App Engine
This is Rietveld 408576698