Chromium Code Reviews

Issue 569323002: Remove VirtualKeyboardUsabilityExperimentTest (Closed)

Created:
6 years, 3 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 3 months ago
Reviewers:
oshima, bshe
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove VirtualKeyboardUsabilityExperimentTest The test was added for keyboard usability experiment which is no longer needed. BUG=413583 TEST=none Committed: https://crrev.com/003db13b9107edee3723ac1a5a3d4d56e9e2ce97 Cr-Commit-Position: refs/heads/master@{#294873}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -38 lines)
M ash/display/virtual_keyboard_window_controller_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments

Messages

Total messages: 8 (2 generated)
Yufeng Shen (Slow to review)
Hey Oshima, This test is crashing after my CL https://codereview.chromium.org/559213002/. I am removing this test ...
6 years, 3 months ago (2014-09-15 17:57:00 UTC) #2
oshima
lgtm In a separate CL, can you (or bshe) remove the code this is testing?
6 years, 3 months ago (2014-09-15 18:08:40 UTC) #3
Yufeng Shen (Slow to review)
On 2014/09/15 18:08:40, oshima wrote: > lgtm > > In a separate CL, can you ...
6 years, 3 months ago (2014-09-15 18:22:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569323002/1
6 years, 3 months ago (2014-09-15 18:25:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as d2c60d3d461cb0e3470db338eaab3b68bf4022d1
6 years, 3 months ago (2014-09-15 19:59:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:03:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/003db13b9107edee3723ac1a5a3d4d56e9e2ce97
Cr-Commit-Position: refs/heads/master@{#294873}

Powered by Google App Engine