Revert of Change SkResourceCache to take a Visitor inside its find().

tests/ImageCacheTest.cpp

  /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkDiscardableMemory.h"
 #include "SkResourceCache.h"
 #include "Test.h"
 
 namespace {
 static void* gGlobalAddress;
 struct TestingKey : public SkResourceCache::Key {
     void*       fPtr;
     intptr_t    fValue;
 
     TestingKey(intptr_t value) : fPtr(&gGlobalAddress), fValue(value) {
         this->init(sizeof(fPtr) + sizeof(fValue));
     }
 };
 struct TestingRec : public SkResourceCache::Rec {
     TestingRec(const TestingKey& key, uint32_t value) : fKey(key), fValue(value) {}
 
     TestingKey  fKey;
     intptr_t    fValue;
 
     virtual const Key& getKey() const SK_OVERRIDE { return fKey; }
     virtual size_t bytesUsed() const SK_OVERRIDE { return sizeof(fKey) + sizeof(fValue); }
-
-    static bool Visitor(const SkResourceCache::Rec& baseRec, void* context) {
-        const TestingRec& rec = static_cast<const TestingRec&>(baseRec);
-        intptr_t* result = (intptr_t*)context;
-        
-        *result = rec.fValue;
-        return true;
-    }
 };
 }
 
 static const int COUNT = 10;
 static const int DIM = 256;
 
-static void test_cache(skiatest::Reporter* reporter, SkResourceCache& cache, bool testPurge) {
+static void test_cache(skiatest::Reporter* reporter, SkResourceCache& cache,
+                       bool testPurge) {
+    SkResourceCache::ID id;
+
     for (int i = 0; i < COUNT; ++i) {
         TestingKey key(i);
-        intptr_t value = -1;
 
-        REPORTER_ASSERT(reporter, !cache.find(key, TestingRec::Visitor, &value));
-        REPORTER_ASSERT(reporter, -1 == value);
+        const TestingRec* rec = (const TestingRec*)cache.findAndLock(key);
+        REPORTER_ASSERT(reporter, NULL == rec);
 
-        cache.add(SkNEW_ARGS(TestingRec, (key, i)));
+        TestingRec* newRec = SkNEW_ARGS(TestingRec, (key, i));
+        const TestingRec* addedRec = (const TestingRec*)cache.addAndLock(newRec);
+        REPORTER_ASSERT(reporter, addedRec);
 
-        REPORTER_ASSERT(reporter, cache.find(key, TestingRec::Visitor, &value));
-        REPORTER_ASSERT(reporter, i == value);
+        const TestingRec* foundRec = (const TestingRec*)cache.findAndLock(key);
+        REPORTER_ASSERT(reporter, foundRec == addedRec);
+        REPORTER_ASSERT(reporter, foundRec->fValue == i);
+        cache.unlock(foundRec);
+        cache.unlock(addedRec);
     }
 
     if (testPurge) {
         // stress test, should trigger purges
         for (size_t i = 0; i < COUNT * 100; ++i) {
             TestingKey key(i);
-            cache.add(SkNEW_ARGS(TestingRec, (key, i)));
+            SkResourceCache::ID id = cache.addAndLock(SkNEW_ARGS(TestingRec, (key, i)));
+            REPORTER_ASSERT(reporter, id);
+            cache.unlock(id);
         }
     }
 
     // test the originals after all that purging
     for (int i = 0; i < COUNT; ++i) {
-        intptr_t value;
-        (void)cache.find(TestingKey(i), TestingRec::Visitor, &value);
+        id = cache.findAndLock(TestingKey(i));
+        if (id) {
+            cache.unlock(id);
+        }
     }
 
     cache.setTotalByteLimit(0);
 }
 
 #include "SkDiscardableMemoryPool.h"
 
 static SkDiscardableMemoryPool* gPool;
 static SkDiscardableMemory* pool_factory(size_t bytes) {
     SkASSERT(gPool);
@@ skipping 19 matching lines @@
         test_cache(reporter, cache, false);
     }
 }
 
 DEF_TEST(ImageCache_doubleAdd, r) {
     // Adding the same key twice should be safe.
     SkResourceCache cache(4096);
 
     TestingKey key(1);
 
-    cache.add(SkNEW_ARGS(TestingRec, (key, 2)));
-    cache.add(SkNEW_ARGS(TestingRec, (key, 3)));
+    SkResourceCache::ID id1 = cache.addAndLock(SkNEW_ARGS(TestingRec, (key, 2)));
+    SkResourceCache::ID id2 = cache.addAndLock(SkNEW_ARGS(TestingRec, (key, 3)));
+    // We don't really care if id1 == id2 as long as unlocking both works.
+    cache.unlock(id1);
+    cache.unlock(id2);
 
     // Lookup can return either value.
-    intptr_t value = -1;
-    REPORTER_ASSERT(r, cache.find(key, TestingRec::Visitor, &value));
-    REPORTER_ASSERT(r, 2 == value || 3 == value);
+    const TestingRec* rec = (const TestingRec*)cache.findAndLock(key);
+    REPORTER_ASSERT(r, rec);
+    REPORTER_ASSERT(r, 2 == rec->fValue || 3 == rec->fValue);
+    cache.unlock(rec);
 }