Issue 569303002: Revert of Change SkResourceCache to take a Visitor inside its find().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 569303002: Revert of Change SkResourceCache to take a Visitor inside its find(). (Closed)

Created:
6 years, 3 months ago by reed1

Modified:
6 years, 3 months ago

Reviewers:
danakj, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Change SkResourceCache to take a Visitor inside its find(). (patchset #2 id:20001 of https://codereview.chromium.org/567393002/) Reason for revert: crashes on android bots, haven't diagnosed yet Original issue's description: > Change SkResourceCache to take a Visitor inside its find(). > > This simplifies the API/contract, in that there are not any exposed > lock/unlock scopes. > > > patch from issue 572573002 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/dee6a8e67db39fcbde2b3bb09be1d088ebb9db8a TBR=mtklein@google.com,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/595aa05efcb504e85358b8d328ac4a9fa1c46e2e

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -101 lines)			Patch
M	bench/ImageCacheBench.cpp	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	src/core/SkBitmapCache.cpp	View	4 chunks	+23 lines, -20 lines	0 comments	Download
M	src/core/SkResourceCache.h	View	5 chunks	+17 lines, -34 lines	0 comments	Download
M	src/core/SkResourceCache.cpp	View	5 chunks	+107 lines, -17 lines	0 comments	Download
M	tests/ImageCacheTest.cpp	View	2 chunks	+30 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Change SkResourceCache to take a Visitor inside its find().

6 years, 3 months ago (2014-09-15 17:14:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569303002/1

6 years, 3 months ago (2014-09-15 17:14:58 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 17:15:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 595aa05efcb504e85358b8d328ac4a9fa1c46e2e