Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 569263002: Fix Cocoa setFrame:display: call type mismatch (Closed)

Created:
6 years, 3 months ago by Jiang Jiang
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Cocoa setFrame:display: call type mismatch -[NSView setFrame:display:] accepts BOOL as the second argument, passing nil only worked by accident. Committed: https://crrev.com/b40f80fada5945194089a42883c389b313c6493e Cr-Commit-Position: refs/heads/master@{#294862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jiang Jiang
6 years, 3 months ago (2014-09-15 15:59:13 UTC) #2
Avi (use Gerrit)
Yikes. LGTM
6 years, 3 months ago (2014-09-15 16:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569263002/1
6 years, 3 months ago (2014-09-15 17:18:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f15bb68b9a096fe77ebe1e185192d3ec63f6c1fd
6 years, 3 months ago (2014-09-15 19:13:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:16:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b40f80fada5945194089a42883c389b313c6493e
Cr-Commit-Position: refs/heads/master@{#294862}

Powered by Google App Engine
This is Rietveld 408576698