Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/run_perf.py

Issue 569213002: Make timeout configurable in performance test runner. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Formatting Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/unittests/run_perf_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index 0022c8e5d02f9e46b1da0696e4cb7e5a38c5435e..920c18d24aac8b4b51d0a3798fbc52ba22a0cf12 100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -164,6 +164,7 @@ class DefaultSentinel(Node):
super(DefaultSentinel, self).__init__()
self.binary = "d8"
self.run_count = 10
+ self.timeout = 60
self.path = []
self.graphs = []
self.flags = []
@@ -198,6 +199,7 @@ class Graph(Node):
self.binary = suite.get("binary", parent.binary)
self.run_count = suite.get("run_count", parent.run_count)
self.run_count = suite.get("run_count_%s" % arch, self.run_count)
+ self.timeout = suite.get("timeout", parent.timeout)
self.units = suite.get("units", parent.units)
self.total = suite.get("total", parent.total)
@@ -463,15 +465,18 @@ def Main(args):
def Runner():
"""Output generator that reruns several times."""
for i in xrange(0, max(1, runnable.run_count)):
- # TODO(machenbach): Make timeout configurable in the suite definition.
- # Allow timeout per arch like with run_count per arch.
- output = commands.Execute(runnable.GetCommand(shell_dir), timeout=60)
+ # TODO(machenbach): Allow timeout per arch like with run_count per
+ # arch.
+ output = commands.Execute(runnable.GetCommand(shell_dir),
+ timeout=runnable.timeout)
print ">>> Stdout (#%d):" % (i + 1)
print output.stdout
if output.stderr: # pragma: no cover
# Print stderr for debugging.
print ">>> Stderr (#%d):" % (i + 1)
print output.stderr
+ if output.timed_out:
+ print ">>> Test timed out after %ss." % runnable.timeout
yield output.stdout
# Let runnable iterate over all runs and handle output.
« no previous file with comments | « no previous file | tools/unittests/run_perf_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698