Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 569173007: Always make context current in ViewManager's BitmapUploader, be laxer in SurfaceResourceHolder (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Always make context current in ViewManager's BitmapUploader, be laxer in SurfaceResourceHolder When in the component build multiple threads (apps) will use the same view manager client lib and could fight over the current GL context, so always make our context current in BitmapUploader. When shutting down abrubtly (i.e. when losing a connection to an app), the client will not necessarily properly unref all resources it uses. DCHECKing here isn't helpful, so just skip over resources that are not fully unreffed. R=ben@chromium.org Committed: https://crrev.com/2504061c3b70cd2dc6748bfe4da2b8e020cecb14 Cr-Commit-Position: refs/heads/master@{#294943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cc/surfaces/surface_resource_holder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/bitmap_uploader.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
6 years, 3 months ago (2014-09-15 22:01:09 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-15 22:07:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569173007/1
6 years, 3 months ago (2014-09-15 22:56:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as ae7ed5cdd21b459c8a07f41087d5b48e3dd5c8f6
6 years, 3 months ago (2014-09-16 00:34:41 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 00:40:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2504061c3b70cd2dc6748bfe4da2b8e020cecb14
Cr-Commit-Position: refs/heads/master@{#294943}

Powered by Google App Engine
This is Rietveld 408576698