Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 569123003: Video Player: Add accessibility annotations to cast menu (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Add accessibility annotations to cast menu BUG=413944 TEST=Instlal ChromeVox and confirms that it speaks both on the icon and on menu item. Committed: https://crrev.com/ead68f6b2d7725c34766a50397f9039a2a4b6da2 Cr-Commit-Position: refs/heads/master@{#295232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M ui/file_manager/video_player/js/video_player.js View 6 chunks +4 lines, -8 lines 0 comments Download
M ui/file_manager/video_player/js/video_player_scripts.js View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-17 03:20:00 UTC) #2
fukino
On 2014/09/17 03:20:00, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm. Thanks!
6 years, 3 months ago (2014-09-17 04:26:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569123003/1
6 years, 3 months ago (2014-09-17 04:26:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f22080c28e1ee6d05e9e3262c78e7b257b7b5776
6 years, 3 months ago (2014-09-17 05:22:49 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 05:23:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ead68f6b2d7725c34766a50397f9039a2a4b6da2
Cr-Commit-Position: refs/heads/master@{#295232}

Powered by Google App Engine
This is Rietveld 408576698