Chromium Code Reviews| Index: chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh |
| diff --git a/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh b/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh |
| index 48b03147263d2ffacbb0aa5410610581d513727f..4a8a7dffd74e5647623690d2479d8bda254ef599 100755 |
| --- a/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh |
| +++ b/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh |
| @@ -10,8 +10,8 @@ if [ $(uname -s) == 'Darwin' ]; then |
| if [ "$(whoami)" == "root" ]; then |
| TARGET_DIR="/Library/Google/Chrome/NativeMessagingHosts" |
| else |
| - TARGET_DIR=\ |
| - "$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts" |
| + TARGET_DIR=" |
| + $HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts" |
|
Sergey Ulanov
2014/09/20 17:50:04
This adds spaces in TARGET_DIR, do I don't think y
Patrick Kettner
2014/09/20 18:00:57
It does add a space, however that space doesn't ch
|
| fi |
| else |
| if [ "$(whoami)" == "root" ]; then |
| @@ -24,17 +24,17 @@ fi |
| HOST_NAME=com.google.chrome.example.echo |
| # Create directory to store native messaging host. |
| -mkdir -p $TARGET_DIR |
| +mkdir -p "$TARGET_DIR" |
| # Copy native messaging host manifest. |
| -cp $DIR/$HOST_NAME.json $TARGET_DIR |
| +cp $DIR/$HOST_NAME.json "$TARGET_DIR" |
| # Update host path in the manifest. |
| HOST_PATH=$DIR/native-messaging-example-host |
| ESCAPED_HOST_PATH=${HOST_PATH////\\/} |
| -sed -i -e "s/HOST_PATH/$ESCAPED_HOST_PATH/" $TARGET_DIR/$HOST_NAME.json |
| +sed -i -e "s/HOST_PATH/$ESCAPED_HOST_PATH/" "$TARGET_DIR/$HOST_NAME.json" |
| # Set permissions for the manifest so that all users can read it. |
| -chmod o+r $TARGET_DIR/$HOST_NAME.json |
| +chmod o+r "$TARGET_DIR/$HOST_NAME.json" |
| echo Native messaging host $HOST_NAME has been installed. |