Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: src/log.h

Issue 569028: Don't inline full VMState's constructor/destructor. (Closed)
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 #endif 88 #endif
89 89
90 90
91 class VMState BASE_EMBEDDED { 91 class VMState BASE_EMBEDDED {
92 #ifdef ENABLE_LOGGING_AND_PROFILING 92 #ifdef ENABLE_LOGGING_AND_PROFILING
93 public: 93 public:
94 inline VMState(StateTag state); 94 inline VMState(StateTag state);
95 inline ~VMState(); 95 inline ~VMState();
96 96
97 StateTag state() { return state_; } 97 StateTag state() { return state_; }
98
98 Address external_callback() { return external_callback_; } 99 Address external_callback() { return external_callback_; }
99 void set_external_callback(Address external_callback) { 100 void set_external_callback(Address external_callback) {
100 external_callback_ = external_callback; 101 external_callback_ = external_callback;
101 } 102 }
102 103
103 private: 104 private:
105 void Initialize(StateTag state);
106 void Destroy();
107
104 bool disabled_; 108 bool disabled_;
105 StateTag state_; 109 StateTag state_;
106 VMState* previous_; 110 VMState* previous_;
107 Address external_callback_; 111 Address external_callback_;
108 #else 112 #else
109 public: 113 public:
110 explicit VMState(StateTag state) {} 114 explicit VMState(StateTag state) {}
111 #endif 115 #endif
112 }; 116 };
113 117
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 // Class that extracts stack trace, used for profiling. 389 // Class that extracts stack trace, used for profiling.
386 class StackTracer : public AllStatic { 390 class StackTracer : public AllStatic {
387 public: 391 public:
388 static void Trace(TickSample* sample); 392 static void Trace(TickSample* sample);
389 }; 393 };
390 394
391 395
392 } } // namespace v8::internal 396 } } // namespace v8::internal
393 397
394 #endif // V8_LOG_H_ 398 #endif // V8_LOG_H_
OLDNEW
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698