Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 568943002: Reland: Convert device::UsbConfigDescriptor and friends to structs. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland: Convert device::UsbConfigDescriptor and friends to structs. These classes do not need to be classes and expecially don't need to be abstract classes as this leads to a complicated implementation and complicated tests. All USB devices no matter the platform will have the same descriptor data. This change follows the model of device::HidDeviceInfo. Relanding this patch (reverted in crrev.com/294640) after restoring the call to libusb_free_config_descriptor that was removed during refactoring and caused failures in the Linux ASan LSan tests. BUG= Committed: https://crrev.com/2191196d13b2896f5ba7bc1c6a3371cb86a7e8eb Cr-Commit-Position: refs/heads/master@{#294734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -843 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 5 chunks +30 lines, -124 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.cc View 7 chunks +40 lines, -48 lines 0 comments Download
M device/usb/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
A device/usb/usb_descriptors.h View 1 chunk +83 lines, -0 lines 0 comments Download
A device/usb/usb_descriptors.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M device/usb/usb_device.h View 2 chunks +3 lines, -4 lines 0 comments Download
M device/usb/usb_device_filter.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 1 chunk +26 lines, -127 lines 0 comments Download
M device/usb/usb_device_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_handle_impl.h View 4 chunks +3 lines, -4 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 3 chunks +23 lines, -18 lines 0 comments Download
M device/usb/usb_device_impl.h View 3 chunks +7 lines, -1 line 0 comments Download
M device/usb/usb_device_impl.cc View 6 chunks +137 lines, -16 lines 0 comments Download
D device/usb/usb_interface.h View 1 chunk +0 lines, -112 lines 0 comments Download
D device/usb/usb_interface_impl.h View 1 chunk +0 lines, -117 lines 0 comments Download
D device/usb/usb_interface_impl.cc View 1 chunk +0 lines, -168 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 2 chunks +45 lines, -63 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 4 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Reilly Grant (use Gerrit)
Please take another look. Only one line (in UsbDeviceImpl::GetConfiguration) has been changed.
6 years, 3 months ago (2014-09-12 22:21:41 UTC) #2
Ken Rockot(use gerrit already)
Ah, freeing the descriptor. LGTM
6 years, 3 months ago (2014-09-12 22:25:44 UTC) #3
dgozman
devtools lgtm
6 years, 3 months ago (2014-09-13 04:52:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568943002/1
6 years, 3 months ago (2014-09-13 04:58:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as fc91d04379cb97c8776e2ca0db73cf08799cbc7f
6 years, 3 months ago (2014-09-13 05:38:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 05:44:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2191196d13b2896f5ba7bc1c6a3371cb86a7e8eb
Cr-Commit-Position: refs/heads/master@{#294734}

Powered by Google App Engine
This is Rietveld 408576698