Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 568933002: Normalize a couple of print preview browser tests. (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Normalize a couple of print preview browser tests. PrintWebViewHelperTest.PrintWithIframe document.write()s into a loaded iframe without a document.close(). This blocks the load event in the parent frame and will soon block load completion notifications. BlockScriptInitiatedPrinting operates on an initial empty document, which can have strange effects. Load one of the html strings provided in that file, just so we have a real document to work with. BUG= Committed: https://crrev.com/87390022e9c1c9bf5e90e062184acce674233252 Cr-Commit-Position: refs/heads/master@{#294736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nate Chapin
A couple of quirks in print_web_view_helper_browsertest.cc that I found as a result of working on ...
6 years, 3 months ago (2014-09-12 22:15:38 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-13 05:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568933002/1
6 years, 3 months ago (2014-09-13 05:56:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a9f14740b2a50376c2bb85fbc1761e85362f8d46
6 years, 3 months ago (2014-09-13 06:53:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 06:56:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87390022e9c1c9bf5e90e062184acce674233252
Cr-Commit-Position: refs/heads/master@{#294736}

Powered by Google App Engine
This is Rietveld 408576698