Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 568923004: Don't set metainfo ID for enhanced bookmarks extension (Closed)

Created:
6 years, 3 months ago by Mike Wittman
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

Don't set metainfo ID for enhanced bookmarks extension The enhanced bookmarks extension is being updated to rely solely on server-generated persistent IDs, eliminating the need to create IDs in Chrome client code. This is effectively a revert of 0f7d5081316ce979b96cc21f9143bf81372ac056 and 224e1d1867596f04e0e1fba030801c41c1b97727. BUG=413378 Committed: https://crrev.com/c35fc9c4a92282824b650d9300b6d34fd9ec93b7 Cr-Commit-Position: refs/heads/master@{#294694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -109 lines) Patch
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 5 chunks +0 lines, -69 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_observer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 21 chunks +20 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mike Wittman
PTAL yoz: chrome/browser/extensions sky: components/bookmarks
6 years, 3 months ago (2014-09-12 21:30:25 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-12 21:32:35 UTC) #3
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-12 21:58:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568923004/1
6 years, 3 months ago (2014-09-12 22:04:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/15177)
6 years, 3 months ago (2014-09-12 22:30:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568923004/1
6 years, 3 months ago (2014-09-12 22:59:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 35d7f6e4d863e86d3cb35525f43491793e5f2a17
6 years, 3 months ago (2014-09-12 23:36:33 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 23:49:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c35fc9c4a92282824b650d9300b6d34fd9ec93b7
Cr-Commit-Position: refs/heads/master@{#294694}

Powered by Google App Engine
This is Rietveld 408576698