Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 568923002: Move unit_tests sources to variables section in .gypi file. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move unit_tests sources to variables section in .gypi file. This is preparing for a GN unit test target that shares the sources list. This change only moves the main files list to minimize merge conflicts in the future steps. TBR=jamesr Committed: https://crrev.com/fbf6db920f83490b1b593e47c9555fd64183475a Cr-Commit-Position: refs/heads/master@{#294693}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1448 lines, -1444 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1448 lines, -1444 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
This is the .gypi change from this patch: https://codereview.chromium.org/559543003/ which was already reviewed. That one ...
6 years, 3 months ago (2014-09-12 20:34:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568923002/1
6 years, 3 months ago (2014-09-12 20:36:02 UTC) #4
jamesr
rslgtm
6 years, 3 months ago (2014-09-12 20:48:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4137) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/8381) mac_chromium_compile_dbg ...
6 years, 3 months ago (2014-09-12 21:24:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568923002/20001
6 years, 3 months ago (2014-09-12 22:23:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 12c791699a4a3de7af8414812f300aa7d3e5fbb9
6 years, 3 months ago (2014-09-12 23:26:08 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 23:40:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbf6db920f83490b1b593e47c9555fd64183475a
Cr-Commit-Position: refs/heads/master@{#294693}

Powered by Google App Engine
This is Rietveld 408576698