Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 568913002: Add a test that uses C++11 features as a compiler canary. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add a test that uses C++11 features as a compiler canary. BUG=skia: Committed: https://skia.googlesource.com/skia/+/86e01df8d1d8848044c3fcc31c1a2008b70fe08c

Patch Set 1 #

Patch Set 2 : ios? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M gyp/common_conditions.gypi View 1 4 chunks +6 lines, -5 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/Cpp11Test.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years, 3 months ago (2014-09-12 20:02:20 UTC) #2
bungeman-skia
lgtm
6 years, 3 months ago (2014-09-12 20:07:27 UTC) #3
mtklein
OK, looks like only the 10.6 compilers are holding this back! I will update the ...
6 years, 3 months ago (2014-09-12 20:51:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568913002/20001
6 years, 3 months ago (2014-09-12 23:54:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 86e01df8d1d8848044c3fcc31c1a2008b70fe08c
6 years, 3 months ago (2014-09-13 00:02:57 UTC) #7
mtklein
6 years, 3 months ago (2014-09-13 00:07:20 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/565213008/ by mtklein@google.com.

The reason for reverting is: nope, nacl and ubuntu local bots (at least) broken.

Powered by Google App Engine
This is Rietveld 408576698