Trigger data reduction proxy unreachable message via on proxy fall back.

components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/metrics/histogram.h"
@@ skipping 61 matching lines @@
   }
 }
 
 DataReductionProxyUsageStats::DataReductionProxyUsageStats(
     DataReductionProxyParams* params,
     MessageLoopProxy* ui_thread_proxy)
     : data_reduction_proxy_params_(params),
       last_bypass_type_(BYPASS_EVENT_TYPE_MAX),
       triggering_request_(true),
       ui_thread_proxy_(ui_thread_proxy),
-      eligible_num_requests_through_proxy_(0),
-      actual_num_requests_through_proxy_(0),
+      num_successful_requests_through_proxy_(0),

[bengr, 2014/09/16 18:48:57]

num_ is implied here and with proxy_net_errors_. I think they can be removed.

[Not at Google. Contact bengr, 2014/09/16 19:34:49]

Prefer keeping it since it makes it more obvious.

+      num_proxy_net_errors_(0),
       unavailable_(false) {
   NetworkChangeNotifier::AddNetworkChangeObserver(this);
 };
 
 DataReductionProxyUsageStats::~DataReductionProxyUsageStats() {
   NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
 };
 
 void DataReductionProxyUsageStats::OnUrlRequestCompleted(
     const net::URLRequest* request, bool started) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
-  if (request->status().status() == net::URLRequestStatus::SUCCESS) {
-    if (data_reduction_proxy_params_->IsDataReductionProxyEligible(request)) {
-      bool was_received_via_proxy =
-          data_reduction_proxy_params_->WasDataReductionProxyUsed(
-              request, NULL);
-      IncrementRequestCounts(was_received_via_proxy);
+  if (request->status().status() == net::URLRequestStatus::SUCCESS &&
+      data_reduction_proxy_params_->WasDataReductionProxyUsed(request, NULL)) {

[bengr, 2014/09/16 18:48:56]

Can params be NULL? If so, check here. If not, DCHECK in the constructor.

[Not at Google. Contact bengr, 2014/09/16 19:34:48]

Added DCHECK in constructor.

+    num_successful_requests_through_proxy_++;
+
+    // To account for the case when the proxy does not work for a little while

[bengr, 2014/09/16 18:48:57]

Why would it not work for a little while?

[Not at Google. Contact bengr, 2014/09/16 19:34:48]

Done.

+    // and then works fine, we reset the counts occasionally.

[bengr, 2014/09/16 18:48:56]

How often? What triggers the reset?

[Not at Google. Contact bengr, 2014/09/16 19:34:48]

Done.

+    if (num_proxy_net_errors_ > 0 &&
+        num_successful_requests_through_proxy_ > 3) {

[bengr, 2014/09/16 18:48:56]

Define these constants in an anonymous namespace above.

[Not at Google. Contact bengr, 2014/09/16 19:34:48]

Done.

+      ClearRequestCounts();
+    } else {
+      MaybeNotifyUnavailability();
     }
   }
 }
 
 void DataReductionProxyUsageStats::OnNetworkChanged(
     NetworkChangeNotifier::ConnectionType type) {
   DCHECK(thread_checker_.CalledOnValidThread());
   ClearRequestCounts();
 }
 
-void DataReductionProxyUsageStats::IncrementRequestCounts(
-    bool was_received_via_proxy) {
-  DCHECK(thread_checker_.CalledOnValidThread());
-  if (was_received_via_proxy) {
-    actual_num_requests_through_proxy_++;
-  }
-  eligible_num_requests_through_proxy_++;
-
-  // To account for the case when the proxy works for a little while and then
-  // gets blocked, we reset the counts occasionally.
-  if (eligible_num_requests_through_proxy_ > 50
-      && actual_num_requests_through_proxy_ > 0) {
-    ClearRequestCounts();
-  } else {
-    MaybeNotifyUnavailability();
-  }
-}
-
 void DataReductionProxyUsageStats::ClearRequestCounts() {
   DCHECK(thread_checker_.CalledOnValidThread());
-  eligible_num_requests_through_proxy_ = 0;
-  actual_num_requests_through_proxy_ = 0;
+  num_successful_requests_through_proxy_ = 0;
+  num_proxy_net_errors_ = 0;
   MaybeNotifyUnavailability();
 }
 
 void DataReductionProxyUsageStats::MaybeNotifyUnavailability() {
   bool prev_unavailable = unavailable_;
-  unavailable_ = (eligible_num_requests_through_proxy_ > 0 &&
-      actual_num_requests_through_proxy_ == 0);
+  unavailable_ = (num_proxy_net_errors_ > 0 &&
+      num_successful_requests_through_proxy_ == 0);

[bengr, 2014/09/16 18:48:56]

Define these constants in an anonymous namespace above.

[Not at Google. Contact bengr, 2014/09/16 19:34:49]

Done.

   if (prev_unavailable != unavailable_) {
      ui_thread_proxy_->PostTask(FROM_HERE, base::Bind(
           &DataReductionProxyUsageStats::NotifyUnavailabilityOnUIThread,
           base::Unretained(this),
           unavailable_));
   }
 }
 
 void DataReductionProxyUsageStats::NotifyUnavailabilityOnUIThread(
     bool unavailable) {
@@ skipping 77 matching lines @@
   }
 
   if (data_reduction_proxy_params_->
           AreDataReductionProxiesBypassed(request, NULL)) {
       RecordBypassedBytes(last_bypass_type_,
                           DataReductionProxyUsageStats::NETWORK_ERROR,
                           content_length);
   }
 }
 
-void DataReductionProxyUsageStats::RecordBypassEventHistograms(
+void DataReductionProxyUsageStats::OnProxyFallback(
     const net::ProxyServer& bypassed_proxy,
-    int net_error) const {
+    int net_error) {
   DataReductionProxyTypeInfo data_reduction_proxy_info;
   if (bypassed_proxy.is_valid() && !bypassed_proxy.is_direct() &&
       data_reduction_proxy_params_->IsDataReductionProxy(
       bypassed_proxy.host_port_pair(), &data_reduction_proxy_info)) {
     if (data_reduction_proxy_info.is_ssl)
       return;
+
+    num_proxy_net_errors_++;
+    MaybeNotifyUnavailability();
+
     if (!data_reduction_proxy_info.is_fallback) {
       RecordDataReductionProxyBypassInfo(
           true, false, bypassed_proxy, BYPASS_EVENT_TYPE_NETWORK_ERROR);
       RecordDataReductionProxyBypassOnNetworkError(
           true, bypassed_proxy, net_error);
     } else {
       RecordDataReductionProxyBypassInfo(
           false, false, bypassed_proxy, BYPASS_EVENT_TYPE_NETWORK_ERROR);
       RecordDataReductionProxyBypassOnNetworkError(
           false, bypassed_proxy, net_error);
@@ skipping 112 matching lines @@
         default:
           break;
       }
       break;
   }
 }
 
 }  // namespace data_reduction_proxy