Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Unified Diff: mojo/services/native_viewport/BUILD.gn

Issue 568883003: Second attempt to land change to remove NativeViewportService and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows component build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/native_viewport/BUILD.gn
diff --git a/mojo/services/native_viewport/BUILD.gn b/mojo/services/native_viewport/BUILD.gn
index 4bd367a02b30bc03d248d17808694743771252cf..25ccfbd967e18d2272f5d3a983c2e71ef829f22b 100644
--- a/mojo/services/native_viewport/BUILD.gn
+++ b/mojo/services/native_viewport/BUILD.gn
@@ -5,10 +5,21 @@
import("//build/config/ui.gni")
import("//mojo/system.gni")
-# GYP version: mojo/mojo_services.gypi:mojo_native_viewport_service_lib
-static_library("native_viewport") {
- output_name = "mojo_native_viewport"
+if (!is_android) {
+ shared_library("native_viewport") {
+ output_name = "mojo_native_viewport_service"
+ deps = [
+ ":lib",
+ "//mojo/services/public/interfaces/native_viewport",
+ ]
+ deps += mojo_system_for_shared_library
+
+ sources = [ "main.cc" ]
+ }
+}
+
+source_set("lib") {
deps = [
"//base",
"//cc/surfaces",
@@ -50,13 +61,6 @@ static_library("native_viewport") {
deps += [ "//mojo:jni_headers" ]
}
- if (is_win) {
- deps += [
- # TODO(GYP)
- # '../ui/platform_window/win/win_window.gyp:win_window',
- ]
- }
-
if (use_x11) {
sources += [ "platform_viewport_x11.cc" ]
deps += [

Powered by Google App Engine
This is Rietveld 408576698