Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: mojo/mojo_services.gypi

Issue 568883003: Second attempt to land change to remove NativeViewportService and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows component build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/mojo_services.gypi
diff --git a/mojo/mojo_services.gypi b/mojo/mojo_services.gypi
index e775c0014a01fed7c6b14cc770d4a7074bb4ceba..b06a8dcf2894f8f5ba37263efdc6df3ef16f72d0 100644
--- a/mojo/mojo_services.gypi
+++ b/mojo/mojo_services.gypi
@@ -272,8 +272,6 @@
{
# GN version: //mojo/services/native_viewport
'target_name': 'mojo_native_viewport_service_lib',
- # This is linked directly into the embedder, so we make it a static_library.
- # TODO(davemoore): Make this a true service.
'type': 'static_library',
'dependencies': [
'../base/base.gyp:base',
@@ -344,6 +342,21 @@
],
},
{
+ 'target_name': 'mojo_native_viewport_service',
+ 'type': 'loadable_module',
+ 'dependencies': [
+ 'mojo_native_viewport_bindings',
+ 'mojo_native_viewport_service_lib',
+ '<(mojo_system_for_loadable_module)',
+ ],
+ 'export_dependent_settings': [
+ 'mojo_native_viewport_bindings',
+ ],
+ 'sources': [
+ 'services/native_viewport/main.cc',
+ ],
+ },
+ {
# GN version: //mojo/services/public/interfaces/navigation
'target_name': 'mojo_navigation_bindings',
'type': 'static_library',
@@ -705,7 +718,7 @@
{
# GN version: //mojo/services/view_manager
'target_name': 'mojo_view_manager',
- 'type': '<(component)',
+ 'type': 'loadable_module',
'dependencies': [
'../base/base.gyp:base',
'../cc/cc.gyp:cc_surfaces',
@@ -715,6 +728,8 @@
'../ui/events/events.gyp:events_base',
'../ui/gfx/gfx.gyp:gfx',
'../ui/gfx/gfx.gyp:gfx_geometry',
+ '../webkit/common/gpu/webkit_gpu.gyp:webkit_gpu',
+ 'mojo_base.gyp:mojo_common_lib',
'mojo_base.gyp:mojo_application_chromium',
'mojo_base.gyp:mojo_common_lib',
'mojo_geometry_bindings',
@@ -727,7 +742,8 @@
'mojo_surfaces_lib',
'mojo_view_manager_bindings',
'mojo_view_manager_common',
- '<(mojo_system_for_component)',
+ 'mojo_gpu_bindings',
+ '<(mojo_system_for_loadable_module)',
],
'sources': [
'services/view_manager/access_policy.h',
@@ -753,6 +769,9 @@
'services/view_manager/window_manager_access_policy.cc',
'services/view_manager/window_manager_access_policy.h',
],
+ 'includes': [
+ 'mojo_public_gles2_for_loadable_module.gypi',
+ ],
'defines': [
'MOJO_VIEW_MANAGER_IMPLEMENTATION',
],
@@ -764,7 +783,6 @@
'dependencies': [
'../base/base.gyp:base',
'../base/base.gyp:test_support_base',
- '../ui/gl/gl.gyp:gl',
],
'sources': [
'services/public/cpp/view_manager/lib/view_manager_test_suite.cc',
@@ -772,12 +790,6 @@
'services/public/cpp/view_manager/lib/view_manager_unittests.cc',
],
'conditions': [
- ['OS=="linux" or OS=="win"', {
- 'dependencies': [
- '../third_party/mesa/mesa.gyp:osmesa',
- 'mojo_native_viewport_service_lib',
- ],
- }],
['use_x11==1', {
'dependencies': [
'../ui/gfx/x/gfx_x11.gyp:gfx_x11',
@@ -796,7 +808,6 @@
'../testing/gtest.gyp:gtest',
'../ui/aura/aura.gyp:aura',
'../ui/gfx/gfx.gyp:gfx_geometry',
- '../ui/gl/gl.gyp:gl',
'mojo_application_manager',
'mojo_base.gyp:mojo_system_impl',
'mojo_base.gyp:mojo_application_chromium',
@@ -814,6 +825,13 @@
'services/view_manager/test_change_tracker.h',
'services/view_manager/view_manager_unittest.cc',
],
+ 'conditions': [
+ ['OS=="win"', {
+ 'dependencies': [
+ '../ui/gfx/gfx.gyp:gfx',
+ ],
+ }],
+ ],
},
{
'target_name': 'package_mojo_view_manager',
@@ -865,7 +883,6 @@
'dependencies': [
'../base/base.gyp:test_support_base',
'../testing/gtest.gyp:gtest',
- '../ui/gl/gl.gyp:gl',
'mojo_application_manager',
'mojo_base.gyp:mojo_system_impl',
'mojo_base.gyp:mojo_environment_chromium',

Powered by Google App Engine
This is Rietveld 408576698