Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: mojo/shell/in_process_dynamic_service_runner.cc

Issue 568883003: Second attempt to land change to remove NativeViewportService and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/desktop/mojo_main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/in_process_dynamic_service_runner.cc
diff --git a/mojo/shell/in_process_dynamic_service_runner.cc b/mojo/shell/in_process_dynamic_service_runner.cc
index 25431a845f2de569c42d743e84cb6214e8982d1e..c98ef0f8fd3d6ed6a35febfe468377651bedf595 100644
--- a/mojo/shell/in_process_dynamic_service_runner.cc
+++ b/mojo/shell/in_process_dynamic_service_runner.cc
@@ -112,8 +112,9 @@ void InProcessDynamicServiceRunner::Run() {
#if !defined(COMPONENT_BUILD)
// Warn on this really weird case: The library requires the GLES2
// control functions, but doesn't require the GLES2 implementation.
- LOG(WARNING) << "App library has MojoSetGLES2ControlThunks, but "
- "doesn't have MojoSetGLES2ImplThunks.";
+ LOG(WARNING) << app_path_.value()
+ << " has MojoSetGLES2ControlThunks, "
+ "but doesn't have MojoSetGLES2ImplThunks.";
#endif
}
@@ -144,9 +145,8 @@ void InProcessDynamicServiceRunner::Run() {
LOG(ERROR) << "MojoMain returned an error: " << result;
} while (false);
- bool success = app_completed_callback_runner_.Run();
+ app_completed_callback_runner_.Run();
app_completed_callback_runner_.Reset();
- LOG_IF(ERROR, !success) << "Failed post run app_completed_callback";
}
} // namespace shell
« no previous file with comments | « mojo/shell/desktop/mojo_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698