Second attempt to land change to remove NativeViewportService and

mojo/mojo.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'conditions': [
       ['mojo_shell_debug_url != ""', {
         'defines': [
           'MOJO_SHELL_DEBUG=1',
@@ skipping 20 matching lines @@
         'mojo_base.gyp:mojo_base',
         'mojo_compositor_app',
         'mojo_content_handler_demo',
         'mojo_echo_client',
         'mojo_echo_service',
         'mojo_example_apptests',
         'mojo_example_service',
         'mojo_geometry_lib',
         'mojo_html_viewer',
         'mojo_js',
-        'mojo_native_viewport_service_lib',
+        'mojo_native_viewport_service',
         'mojo_network_service',
         'mojo_pepper_container_app',
         'mojo_png_viewer',
         'mojo_sample_app',
         'mojo_shell',
         'mojo_shell_lib',
         'mojo_shell_tests',
         'mojo_surfaces_app',
         'mojo_surfaces_app',
         'mojo_surfaces_child_app',
@@ skipping 87 matching lines @@
       ],
     },
     {
       # GN version: //mojo/shell:lib
       'target_name': 'mojo_shell_lib',
       'type': 'static_library',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:base_static',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-        '../net/net.gyp:net',
-        '../url/url.gyp:url_lib',
         'mojo_application_manager',
         'mojo_base.gyp:mojo_application_bindings',
         'mojo_base.gyp:mojo_common_lib',
         'mojo_base.gyp:mojo_gles2_impl',
         'mojo_base.gyp:mojo_system_impl',
         'mojo_base.gyp:mojo_application_chromium',
         'mojo_external_service_bindings',
-        'mojo_native_viewport_service_lib',
         'mojo_network_bindings',
         'mojo_spy',
       ],
       'includes': [ 'public/tools/bindings/mojom_bindings_generator.gypi' ],
       'sources': [
         'shell/app_child_process.cc',
         'shell/app_child_process.h',
         'shell/app_child_process.mojom',
         'shell/app_child_process_host.cc',
         'shell/app_child_process_host.h',
@@ skipping 17 matching lines @@
         'shell/out_of_process_dynamic_service_runner.cc',
         'shell/out_of_process_dynamic_service_runner.h',
         'shell/switches.cc',
         'shell/switches.h',
         'shell/task_runners.cc',
         'shell/task_runners.h',
         'shell/test_child_process.cc',
         'shell/test_child_process.h',
         'shell/ui_application_loader_android.cc',
         'shell/ui_application_loader_android.h',
-        'shell/view_manager_loader.cc',
-        'shell/view_manager_loader.h',
       ],
       'conditions': [
+        ['component=="shared_library"', {
+          'dependencies': [
+            '../ui/gl/gl.gyp:gl',
+          ],
+        }],
         ['OS=="linux"', {
           'dependencies': [
             '../build/linux/system.gyp:dbus',
             '../dbus/dbus.gyp:dbus',
           ],
         }],
         ['OS=="android"', {
           'dependencies': [
             'mojo_network_service_lib',
+            'mojo_native_viewport_service_lib',
           ],
           'sources': [
             'shell/network_application_loader.cc',
             'shell/network_application_loader.h',
           ],
         }],
-        ['use_aura==1', {
-          'dependencies': [
-            # These are only necessary as long as we hard code use of ViewManager.
-            '../skia/skia.gyp:skia',
-            'mojo_view_manager',
-            'mojo_view_manager_bindings',
-          ],
-        }, {  # use_aura==0
-          'sources!': [
-            'shell/view_manager_loader.cc',
-            'shell/view_manager_loader.h',
-          ],
-        }],
       ],
     },
     {
       # GN version: //mojo/shell:test_support
       'target_name': 'mojo_shell_test_support',
       'type': 'static_library',
       'dependencies': [
-        '../base/base.gyp:base',
         '../base/base.gyp:base_static',
-        '../url/url.gyp:url_lib',
-        'mojo_application_manager',
         'mojo_base.gyp:mojo_system_impl',
         'mojo_shell_lib',
       ],
       'sources': [
         'shell/shell_test_helper.cc',
         'shell/shell_test_helper.h',
       ],
     },
     {
       # GN version: //mojo/shell
       'target_name': 'mojo_shell',
       'type': 'executable',
       'dependencies': [
         '../base/base.gyp:base',
-        '../ui/gl/gl.gyp:gl',
-        '../url/url.gyp:url_lib',
-        'mojo_application_manager',
         'mojo_base.gyp:mojo_common_lib',
         'mojo_base.gyp:mojo_environment_chromium',
-        'mojo_base.gyp:mojo_system_impl',
         'mojo_shell_lib',
       ],
-      'conditions': [
-        ['use_ozone==1', {
-          'dependencies': [
-            '../ui/ozone/ozone.gyp:ozone',
-          ],
-        }],
-      ],
       'sources': [
         'shell/desktop/mojo_main.cc',
       ],
+      'conditions': [
+        ['component=="shared_library"', {

[jamesr, 2014/09/16 19:19:20]

why is this dependency component build only?  if shell/desktop/mojo_main.cc uses
things from ui/gfx/, it should declare the dependency on ui/gfx/ in the static
and component builds. if it doesn't, it shouldn't have a dependency in either

[DaveMoore, 2014/09/16 20:12:37]

I was protecting the call with an #ifdef but not the include. Changed to do that
now.

+          'dependencies': [
+            '../ui/gfx/gfx.gyp:gfx',
+          ],
+        }],
+      ],
     },
     {
       # GN version: //mojo/shell:mojo_shell_tests
       'target_name': 'mojo_shell_tests',
       'type': '<(gtest_target_type)',
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../base/base.gyp:test_support_base',
         '../testing/gtest.gyp:gtest',
         '../net/net.gyp:net_test_support',
-        # TODO(vtl): We don't currently need this, but I imagine we will soon.
-        # '../ui/gl/gl.gyp:gl',
         '../url/url.gyp:url_lib',
         'mojo_application_manager',
         'mojo_base.gyp:mojo_common_lib',
         'mojo_base.gyp:mojo_environment_chromium',
         'mojo_base.gyp:mojo_system_impl',
         'mojo_shell_lib',
         'mojo_test_app',
         'mojo_test_request_tracker_app',
         'mojo_test_service_bindings',
       ],
@@ skipping 17 matching lines @@
     {
       # GN version: //mojo/application_manager
       'target_name': 'mojo_application_manager',
       'type': '<(component)',
       'defines': [
         'MOJO_APPLICATION_MANAGER_IMPLEMENTATION',
       ],
       'dependencies': [
         '../base/base.gyp:base',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
-        '../net/net.gyp:net',
         '../url/url.gyp:url_lib',
         'mojo_content_handler_bindings',
         'mojo_network_bindings',
         'mojo_base.gyp:mojo_application_bindings',
         'mojo_base.gyp:mojo_common_lib',
         'mojo_base.gyp:mojo_environment_chromium',
         '<(mojo_system_for_component)',
       ],
       'sources': [
         'application_manager/application_loader.cc',
@@ skipping 141 matching lines @@
         {
           # GN version: //mojo/aura
           'target_name': 'mojo_aura_support',
           'type': 'static_library',
           'dependencies': [
             '../cc/cc.gyp:cc',
             '../ui/aura/aura.gyp:aura',
             '../ui/compositor/compositor.gyp:compositor',
             '../ui/events/events.gyp:events',
             '../ui/events/events.gyp:events_base',
-            '../ui/gl/gl.gyp:gl',
             '../webkit/common/gpu/webkit_gpu.gyp:webkit_gpu',
             'mojo_cc_support',
             'mojo_native_viewport_bindings',
           ],
           'includes': [
             'mojo_public_gles2_for_loadable_module.gypi',
           ],
           'sources': [
             'aura/aura_init.cc',
             'aura/aura_init.h',
@@ skipping 120 matching lines @@
             'mojo_python_bindings',
             'mojo_python_embedder',
             'mojo_python_system',
           ],
           'includes': [ '../third_party/cython/python_module.gypi' ],
         },
       ],
     }],
   ],
 }