Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 568873004: Cleanup: Remove base/file_util.h. Convert remaining references. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove base/file_util.h. Convert remaining references. TBR=brettw@chromium.org Committed: https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18 Cr-Commit-Position: refs/heads/master@{#294729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M android_webview/browser/renderer_host/print_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/cookie_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D base/file_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
TBR
6 years, 3 months ago (2014-09-13 02:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568873004/1
6 years, 3 months ago (2014-09-13 02:06:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa82e65c2b7534497c60cc4c9bdb6dfcd9f114d7
6 years, 3 months ago (2014-09-13 03:02:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d63c4898c2da5a286d01f80229baeb914f99f18 Cr-Commit-Position: refs/heads/master@{#294729}
6 years, 3 months ago (2014-09-13 03:04:09 UTC) #6
brettw
yay! lgtm
6 years, 3 months ago (2014-09-13 04:37:26 UTC) #7
Lei Zhang
On 2014/09/13 04:37:26, brettw wrote: > yay! lgtm There's some broken internal projects and there's ...
6 years, 3 months ago (2014-09-13 20:57:55 UTC) #8
Lei Zhang
6 years, 3 months ago (2014-09-13 20:58:49 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/565803006/ by thestig@chromium.org.

The reason for reverting is: Broke some internal builds. Need to give them a
chance to fix their builds..

Powered by Google App Engine
This is Rietveld 408576698