android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java - Issue 568873002: Start server thread in new TestWebServer.start() method rather than constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java

Issue 568873002: Start server thread in new TestWebServer.start() method rather than constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: silence findbugs static assignment warning Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java b/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java

index 13f8f807b534ad0a7b511ba82cb2046cc39cacb8..5f244f402b43f03691c5424dbeab38e922360bca 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestWebServer.java

@@ -34,7 +34,7 @@ public class VideoTestWebServer {

private TestWebServer mTestWebServer;

public VideoTestWebServer(Context context) throws Exception {

- mTestWebServer = new TestWebServer(false);

+ mTestWebServer = TestWebServer.start();

List<Pair<String, String>> headers = getWebmHeaders(true);

mOnePixelOneFrameWebmURL = mTestWebServer.setResponseBase64("/" +

ONE_PIXEL_ONE_FRAME_WEBM_FILENAME,