android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java - Issue 568873002: Start server thread in new TestWebServer.start() method rather than constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

Issue 568873002: Start server thread in new TestWebServer.start() method rather than constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: silence findbugs static assignment warning Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

index 9f597e6b7dc4a1eed6e72651f3c6cdbef35c4fe5..f22bb1cef7a5207fb84e119fcf25d25ba8e9037f 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java

@@ -61,9 +61,8 @@ public class CookieManagerStartupTest extends AwTestBase {

@MediumTest

@Feature({"AndroidWebView"})

public void testStartup() throws Throwable {

- TestWebServer webServer = null;

+ TestWebServer webServer = TestWebServer.start();

try {

- webServer = new TestWebServer(false);

String path = "/cookie_test.html";

String url = webServer.setResponse(path, CommonResources.ABOUT_HTML, null);

@@ -87,7 +86,7 @@ public class CookieManagerStartupTest extends AwTestBase {

assertEquals("count=42", cookieManager.getCookie(url));

} finally {

- if (webServer != null) webServer.shutdown();

+ webServer.shutdown();

}