Issue 568853002: Quick fix for backslash in ascii art interpreted as multi-line comment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 568853002: Quick fix for backslash in ascii art interpreted as multi-line comment (Closed)

Created:
6 years, 3 months ago by dmazzoni

Modified:
6 years, 3 months ago

Reviewers:
Chirantan Ekbote, xiyuan

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@webview_accessibility

Project:
chromium

Visibility:
Public.

More Reviews

Description

Quick fix for backslash in ascii art interpreted as multi-line comment BUG=none TBR=chirantan,xiyuan NOTRY=true Committed: https://crrev.com/26215c3094bcd31ce55a854501da8ce702d79fa4 Cr-Commit-Position: refs/heads/master@{#294635}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/chromeos/ui/accessibility_focus_ring.h	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568853002/1

6 years, 3 months ago (2014-09-12 17:32:30 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 57e4967c3cf47797f96dafe93b249e2f18871c52

6 years, 3 months ago (2014-09-12 19:38:11 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-12 19:40:59 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/26215c3094bcd31ce55a854501da8ce702d79fa4
Cr-Commit-Position: refs/heads/master@{#294635}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages