Issue 568823002: Add more debugging for newly failing assert (DM on Xoom bots).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 568823002: Add more debugging for newly failing assert (DM on Xoom bots). (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
tfarina

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add more debugging for newly failing assert (DM on Xoom bots). BUG=skia: Committed: https://skia.googlesource.com/skia/+/11fca3f29f0117eda798c67fafde40465d9903e1

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkGeometry.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mtklein_C

Committed patchset #1 (id:1) manually as 11fca3f (presubmit successful).

6 years, 3 months ago (2014-09-12 16:17:33 UTC) #1

tfarina

6 years, 3 months ago (2014-09-12 17:16:23 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/568823002/diff/1/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/568823002/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:105: SkASSERTF(r >= 0 && r < SK_Scalar1, "numer %f,
denom %f, r %f", numer, denom, r);
lgtm (rubber-stamp).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages