Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ppapi/proxy/plugin_globals.h

Issue 568793002: PPAPI: Fix GetBrowserInterface race conditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/plugin_globals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_globals.h
diff --git a/ppapi/proxy/plugin_globals.h b/ppapi/proxy/plugin_globals.h
index 5dc614d239bd72f24e84a11b9fd8290f72facdf8..04c333ca93a72393f9d5af70313009d095620e44 100644
--- a/ppapi/proxy/plugin_globals.h
+++ b/ppapi/proxy/plugin_globals.h
@@ -99,10 +99,12 @@ class PPAPI_PROXY_EXPORT PluginGlobals : public PpapiGlobals {
return &plugin_var_tracker_;
}
- // The embedder should call set_proxy_delegate during startup.
- void set_plugin_proxy_delegate(PluginProxyDelegate* d) {
- plugin_proxy_delegate_ = d;
- }
+ // The embedder should call SetPluginProxyDelegate during startup.
+ void SetPluginProxyDelegate(PluginProxyDelegate* d);
+ // The embedder may choose to call ResetPluginProxyDelegate during shutdown.
+ // After that point, it's unsafe to call most members of PluginGlobals,
+ // and GetBrowserSender will return NULL.
+ void ResetPluginProxyDelegate();
// Returns the TLS slot that holds the message loop TLS.
//
« no previous file with comments | « ppapi/proxy/plugin_dispatcher.cc ('k') | ppapi/proxy/plugin_globals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698