Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 568783002: Remove deoptimization by patching the call stack. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove deoptimization by patching the call stack. We go back to patching the code for lazy deoptimization because ICs need the on-stack return address to read/update the IC address/state. The change also fixes bunch of tests, mostly by adding more deoptimization points. (We still need to add code to ensure lazy deopt patching does not overwrite ICs and other lazy deopts; this is coming next.) BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23934

Patch Set 1 #

Patch Set 2 : Remove the platform dependent code for reloc table allocation. #

Patch Set 3 : Revert temporary comment in a test. #

Patch Set 4 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -179 lines) Patch
M src/compiler/ast-graph-builder.cc View 4 chunks +8 lines, -1 line 0 comments Download
M src/compiler/code-generator.h View 4 chunks +10 lines, -29 lines 0 comments Download
M src/compiler/code-generator.cc View 1 11 chunks +32 lines, -37 lines 1 comment Download
M src/compiler/linkage.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/deoptimizer.h View 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 4 chunks +2 lines, -44 lines 0 comments Download
M src/objects.cc View 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/safepoint-table.h View 9 chunks +9 lines, -48 lines 0 comments Download
M src/safepoint-table.cc View 5 chunks +3 lines, -7 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 3 chunks +23 lines, -2 lines 0 comments Download
M test/mjsunit/regress/poly_count_operation.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 3 months ago (2014-09-15 05:18:40 UTC) #2
Benedikt Meurer
LGTM with comment https://codereview.chromium.org/568783002/diff/60001/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/568783002/diff/60001/src/compiler/code-generator.cc#newcode52 src/compiler/code-generator.cc:52: if (!info->IsStub()) { Do we really ...
6 years, 3 months ago (2014-09-15 08:23:15 UTC) #3
Jarin
6 years, 3 months ago (2014-09-15 09:21:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 23934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698