Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 568763004: Support distributing vsync info with surfaces. (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support distributing vsync info with surfaces. For now the vsync signal can be sent to the browser compositor, which will handle distributing it like before. BUG= Committed: https://crrev.com/c6bf8b941a80b88202c4a6d90ad2047bee6f8885 Cr-Commit-Position: refs/heads/master@{#296126}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M cc/surfaces/display.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M cc/surfaces/display_client.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/onscreen_display_client.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/compositor/onscreen_display_client.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/compositor/surface_display_output_surface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/surface_display_output_surface.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbauman
6 years, 3 months ago (2014-09-16 00:28:21 UTC) #2
jamesr
https://codereview.chromium.org/568763004/diff/20001/content/browser/compositor/onscreen_display_client.cc File content/browser/compositor/onscreen_display_client.cc (right): https://codereview.chromium.org/568763004/diff/20001/content/browser/compositor/onscreen_display_client.cc#newcode38 content/browser/compositor/onscreen_display_client.cc:38: surface_display_output_surface_->ReceivedVSyncParameters(timebase, interval); we have an output_surface_ member already, and ...
6 years, 3 months ago (2014-09-17 05:47:11 UTC) #3
jbauman
On 2014/09/17 05:47:11, jamesr wrote: > https://codereview.chromium.org/568763004/diff/20001/content/browser/compositor/onscreen_display_client.cc > File content/browser/compositor/onscreen_display_client.cc (right): > > https://codereview.chromium.org/568763004/diff/20001/content/browser/compositor/onscreen_display_client.cc#newcode38 > ...
6 years, 3 months ago (2014-09-17 19:38:48 UTC) #4
jamesr
OK I think I get it, but this sure is confusing. lgtm
6 years, 3 months ago (2014-09-22 22:57:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568763004/40001
6 years, 3 months ago (2014-09-23 01:33:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 22054cc7bc6ad1fbe2fdd090609c249cc7942f30
6 years, 3 months ago (2014-09-23 01:51:38 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 01:52:31 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c6bf8b941a80b88202c4a6d90ad2047bee6f8885
Cr-Commit-Position: refs/heads/master@{#296126}

Powered by Google App Engine
This is Rietveld 408576698