Issue 568763002: Replace HTMLMediaElement::player() calls with webMediaPlayer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 568763002: Replace HTMLMediaElement::player() calls with webMediaPlayer() (Closed)

Created:
6 years, 3 months ago by rtakacs

Modified:
6 years, 3 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, blink-reviews-html_chromium.org, zoltan1, eae+blinkwatch, philipj_slow, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, nessy, jchaffraix+rendering, blink-reviews-rendering, pdr., vcarbune.chromium, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Replace HTMLMediaElement::player() calls with webMediaPlayer() Removed player() calls and use webMediaPlayer() instead since it is enough to check the MediaPlayer existance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182042

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -7 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderVideo.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

philipj_slow

LGTM, I didn't know there was so little left to do here.

6 years, 3 months ago (2014-09-16 08:14:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568763002/1

6 years, 3 months ago (2014-09-16 08:17:03 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 08:53:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182042

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages