Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 568763002: Replace HTMLMediaElement::player() calls with webMediaPlayer() (Closed)

Created:
6 years, 3 months ago by rtakacs
Modified:
6 years, 3 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, blink-reviews-html_chromium.org, zoltan1, eae+blinkwatch, philipj_slow, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, nessy, jchaffraix+rendering, blink-reviews-rendering, pdr., vcarbune.chromium, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace HTMLMediaElement::player() calls with webMediaPlayer() Removed player() calls and use webMediaPlayer() instead since it is enough to check the MediaPlayer existance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rtakacs
6 years, 3 months ago (2014-09-15 19:37:52 UTC) #2
philipj_slow
LGTM, I didn't know there was so little left to do here.
6 years, 3 months ago (2014-09-16 08:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568763002/1
6 years, 3 months ago (2014-09-16 08:17:03 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 08:53:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182042

Powered by Google App Engine
This is Rietveld 408576698