Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 568743003: Fixpoint typing has to consider all imprecise nodes (Closed)

Created:
6 years, 3 months ago by rossberg
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fixpoint typing has to consider all imprecise nodes R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23931

Patch Set 1 #

Patch Set 2 : Changed to work on TOT; updated test statuses #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -45 lines) Patch
M src/compiler/typer.cc View 1 2 chunks +13 lines, -5 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -30 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 chunks +0 lines, -5 lines 0 comments Download
M test/webkit/webkit.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 3 months ago (2014-09-12 12:42:39 UTC) #1
Jarin
lgtm. Could you possibly enable the tests that it fixes? (in mjsunit.status)
6 years, 3 months ago (2014-09-12 13:59:30 UTC) #2
rossberg
6 years, 3 months ago (2014-09-15 09:04:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23931.

Powered by Google App Engine
This is Rietveld 408576698