Move transient/temporary RenderSVGResource state out of SVGInlineTextBox

Move transient/temporary RenderSVGResource state out of SVGInlineTextBox

The SVGInlineTextBox member variable |m_paintingResource| is only set
temporarily within paintTextWithShadows and paintDecorationWithStyle, and
is only accessed from the methods that do setup and teardown of it. This
makes it possible to remove it from SVGInlineTextBox and instead manage it
in through a variable on the stack.
The lifetime management is kept manual/the same as previously. The
interaction with TextRun::RenderingContext is changed to be passed as a
parameter to the added "scope" object in order to simplify the interface
a bit.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181904

[fs, 2014-09-12 10:49:17]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[f(malita), 2014-09-12 13:40:56]

Nice, lgtm!

https://codereview.chromium.org/568723002/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGInlineTextBox.cpp (right):

https://codereview.chromium.org/568723002/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGInlineTextBox.cpp:347:
PaintingResourceScope(RenderObject& renderer, TextRun::RenderingContext*
renderingContext = 0)
We could try to go full RAII with this class: acquire the resource in the ctor,
release in the dtor, add an isAcquired() method for client tests and drop the
explicit acquire/release methods. Not sure of all the implications, maybe
something to look into later.

[fs, 2014-09-12 14:01:52]

On 2014/09/12 13:40:56, Florin Malita wrote:
> Nice, lgtm!

Thanks!

>
https://codereview.chromium.org/568723002/diff/1/Source/core/rendering/svg/SV...
> File Source/core/rendering/svg/SVGInlineTextBox.cpp (right):
> 
>
https://codereview.chromium.org/568723002/diff/1/Source/core/rendering/svg/SV...
> Source/core/rendering/svg/SVGInlineTextBox.cpp:347:
> PaintingResourceScope(RenderObject& renderer, TextRun::RenderingContext*
> renderingContext = 0)
> We could try to go full RAII with this class: acquire the resource in the
ctor,
> release in the dtor, add an isAcquired() method for client tests and drop the
> explicit acquire/release methods. Not sure of all the implications, maybe
> something to look into later.

Yeah, I pondered that, and I'll probably get to it eventually =). I have some
pending patches that ought to make that a bit easier though (==less state), so
those first...

[fs, 2014-09-12 14:02:03]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-09-12 14:02:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568723002/1

[commit-bot: I haz the power, 2014-09-12 14:07:22]

Committed patchset #1 (id:1) as 181904