LayoutTests/fast/dom/idl-dictionary-unittest.html - Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/idl-dictionary-unittest.html

Issue 568703002: IDL: Values for dictionaries should be a object, null or undefined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove assertion and added a guard Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description('IDL dictionary unittest');	4 description('IDL dictionary unittest');

5	5

6 if (window.internals && internals.dictionaryTest) {	6 if (window.internals && internals.dictionaryTest) {

7 var dictionaryTest = window.internals.dictionaryTest();	7 var dictionaryTest = window.internals.dictionaryTest();

8	8

9 debug('Test for setting an empty dictionary');	9 debug('Test for setting an empty dictionary');

10 dictionaryTest.set({});	10 dictionaryTest.set({});

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99	99

100 debug('Test for setting invalid member');	100 debug('Test for setting invalid member');

101 dictionaryTest.set({invalidMember: 'shouldNotBeSet'});	101 dictionaryTest.set({invalidMember: 'shouldNotBeSet'});

102 dict = dictionaryTest.get();	102 dict = dictionaryTest.get();

103 shouldBeUndefined('dict.invalidMember');	103 shouldBeUndefined('dict.invalidMember');

104 debug('');	104 debug('');

105	105

106 debug('Test for setting invalid enum value');	106 debug('Test for setting invalid enum value');

107 shouldThrow("dictionaryTest.set({enumMember: 'invalid'})");	107 shouldThrow("dictionaryTest.set({enumMember: 'invalid'})");

108 debug('');	108 debug('');

	109

	110 debug('Test for passing invalid dictionary values');

	111 shouldThrow("dictionaryTest.set(42)");

	112 shouldThrow("dictionaryTest.set('string')");

	113 debug('');

109 }	114 }

110 </script>	115 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt » ('j') | Source/bindings/templates/methods.cpp » ('J')