Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(559)

Issue 5687003: New heap profiler: add support for progress reporting and control. (Closed)

Created:
7 years ago by mnaganov (inactive)
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

New heap profiler: add support for progress reporting and control. As taking a snapshot of a large heap takes noticeable time, it's good to be able to monitor and control it. The change itself is small, big code deletes and additions are in fact moves. The only significant change is simplification of approximated retained sizes calculation algorithm. Committed: http://code.google.com/p/v8/source/detail?r=5978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -205 lines) Patch
M include/v8.h View 1 chunk +18 lines, -0 lines 0 comments Download
M include/v8-profiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap-profiler.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/heap-profiler.cc View 2 chunks +23 lines, -10 lines 0 comments Download
M src/profile-generator.h View 10 chunks +21 lines, -20 lines 0 comments Download
M src/profile-generator.cc View 7 chunks +207 lines, -166 lines 0 comments Download
M src/profile-generator-inl.h View 2 chunks +13 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +47 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
7 years ago (2010-12-10 14:51:32 UTC) #1
Søren Thygesen Gjesse
7 years ago (2010-12-13 07:52:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 0eb02b776