Chromium Code Reviews
Help | Chromium Project | Sign in
(482)

Issue 5687003: New heap profiler: add support for progress reporting and control. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Mikhail Naganov (Cr)
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

New heap profiler: add support for progress reporting and control.

As taking a snapshot of a large heap takes noticeable time, it's
good to be able to monitor and control it.

The change itself is small, big code deletes and additions are in
fact moves. The only significant change is simplification of
approximated retained sizes calculation algorithm.

Committed: http://code.google.com/p/v8/source/detail?r=5978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -205 lines) Lint Patch
M include/v8.h View 1 chunk +18 lines, -0 lines 0 comments 1 errors Download
M include/v8-profiler.h View 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M src/api.cc View 2 chunks +4 lines, -2 lines 0 comments 0 errors Download
M src/heap-profiler.h View 2 chunks +12 lines, -4 lines 0 comments 0 errors Download
M src/heap-profiler.cc View 2 chunks +23 lines, -10 lines 0 comments 0 errors Download
M src/profile-generator.h View 10 chunks +21 lines, -20 lines 0 comments 0 errors Download
M src/profile-generator.cc View 7 chunks +207 lines, -166 lines 0 comments 0 errors Download
M src/profile-generator-inl.h View 2 chunks +13 lines, -1 line 0 comments 0 errors Download
M test/cctest/test-heap-profiler.cc View 1 chunk +47 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Mikhail Naganov (Cr)
3 years, 4 months ago #1
Søren Thygesen Gjesse
3 years, 4 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6