Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 568673003: Video Player: Don't check the volume value on unmuting (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Don't check the volume value on unmuting We ignore the small volume change for preventing drift but we should not do it on un-muting. BUG=412970 TEST=manual R=fukino@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/cc9239b062b89c73f80bd7f5aaf39e9a52a45221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/file_manager/video_player/js/cast/cast_video_element.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yoshiki
@fukino-san, PTAL.
6 years, 3 months ago (2014-09-12 05:55:20 UTC) #2
fukino
On 2014/09/12 05:55:20, yoshiki wrote: > @fukino-san, PTAL. The change is lgtm, but the but ...
6 years, 3 months ago (2014-09-12 06:13:43 UTC) #3
yoshiki
On 2014/09/12 06:13:43, fukino wrote: > On 2014/09/12 05:55:20, yoshiki wrote: > > @fukino-san, PTAL. ...
6 years, 3 months ago (2014-09-12 06:31:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568673003/1
6 years, 3 months ago (2014-09-12 06:32:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14882)
6 years, 3 months ago (2014-09-12 06:49:23 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc9239b062b89c73f80bd7f5aaf39e9a52a45221 Cr-Commit-Position: refs/heads/master@{#294577}
6 years, 3 months ago (2014-09-12 12:44:18 UTC) #9
yoshiki
6 years, 3 months ago (2014-09-12 12:44:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as cc9239b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698