Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 568643003: Reland dd7edfa67: Switch Mac over to BoringSSL from NSS. (Closed)

Created:
6 years, 3 months ago by davidben
Modified:
6 years, 3 months ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews, agl
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland dd7edfa67: Switch Mac over to BoringSSL from NSS. This is a reland of dd7edfa67 which was reverted in 80a9a88f4c for build failures. It also includes a BoringSSL roll and build changes to avoid adding a static initializer. This is a much much larger change than the diff suggests. If it breaks something, please revert first and ask questions later. BUG=338885 TBR=brettw Committed: https://crrev.com/71c13e6ac01d5cdc49ca40e8e9301d5142d85018 Cr-Commit-Position: refs/heads/master@{#294589}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M crypto/openssl_util.cc View 1 chunk +0 lines, -1 line 1 comment Download
M third_party/boringssl/BUILD.gn View 1 chunk +4 lines, -1 line 2 comments Download
M third_party/boringssl/boringssl.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/boringssl/boringssl.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
davidben
Will give this another go tomorrow morning once all the try jobs clear. The static ...
6 years, 3 months ago (2014-09-12 00:31:28 UTC) #2
Ryan Sleevi
lgtm https://codereview.chromium.org/568643003/diff/1/third_party/boringssl/BUILD.gn File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/568643003/diff/1/third_party/boringssl/BUILD.gn#newcode36 third_party/boringssl/BUILD.gn:36: "BORINGSSL_NO_STATIC_INITIALIZER", Just to confirm I'm reading https://boringssl-review.googlesource.com/#/c/1770/ right, ...
6 years, 3 months ago (2014-09-12 00:36:27 UTC) #3
davidben
https://codereview.chromium.org/568643003/diff/1/third_party/boringssl/BUILD.gn File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/568643003/diff/1/third_party/boringssl/BUILD.gn#newcode36 third_party/boringssl/BUILD.gn:36: "BORINGSSL_NO_STATIC_INITIALIZER", On 2014/09/12 00:36:27, Ryan Sleevi wrote: > Just ...
6 years, 3 months ago (2014-09-12 00:40:00 UTC) #4
davidben
(Moving brettw to TBR since the build/ changes are exactly the same as the original ...
6 years, 3 months ago (2014-09-12 14:20:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568643003/1
6 years, 3 months ago (2014-09-12 14:23:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 60f7406eba53ce0cca97f89b23e3a15a977b7cb3
6 years, 3 months ago (2014-09-12 15:12:25 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 15:15:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71c13e6ac01d5cdc49ca40e8e9301d5142d85018
Cr-Commit-Position: refs/heads/master@{#294589}

Powered by Google App Engine
This is Rietveld 408576698